search

xamarin / GooglePlayServicesComponents

Other
313 stars 145 forks source link

[utilities.cake] Only look for namespaces in "obj" assemblies. #766

Closed jpobst closed 1 year ago

jpobst commented 1 year ago

Context: https://github.com/xamarin/AndroidX/pull/722

For some reason, 0.2.0-alpha4 of Xamarin.Legacy.Sdk causes package dependencies to be placed in the /bin directory whereas previously they were not. Our published namespace script looks for all .dll's in the /generated directory, which previously did not include dependencies. This resulted in adding namespaces that were in dependencies and not just the assemblies packaged in this repository.

To fix this, we can restrict ourselves to looking for assemblies in the /obj directory, which does not contain dependency assemblies.

jpobst commented 1 year ago

Mac is broken on main, so this should be considered "green". 😁

moljac commented 1 year ago

Mac is broken on main, so this should be considered "green". 😁

Finally reproducible on CI. Thanks.

seems like 

#addin nuget:?package=HolisticWare.Xamarin.Tools.ComponentGovernance&version=0.0.1.2

transitively pulls in some older packages.

Interesting: the same code works in AX without any problem.