search

xamarin / GooglePlayServicesComponents

Other
313 stars 145 forks source link

Manual updates 20240325 bumps #851

Closed moljac closed 3 months ago

moljac commented 3 months ago

Google Play Services Version (eg: 8.4.0):

Does this change any of the generated binding API's?

Describe your contribution

jpobst commented 3 months ago 
D:\a\_work\1\s\samples\dotnet\BuildAllPlayDotNet\MainActivity.cs(8,58): error CS0234: The type or namespace name 'AssetPackStateUpdateListenerWrapper' does not exist in the namespace 'Xamarin.Google.Android.Play.Core.AssetPacks' (are you missing an assembly reference?) [D:\a\_work\1\s\samples\dotnet\BuildAllPlayDotNet\BuildAllPlayDotNet.csproj::TargetFramework=net6.0-android]
D:\a\_work\1\s\samples\dotnet\BuildAllPlayDotNet\MainActivity.cs(35,47): error CS0246: The type or namespace name 'AssetPackStateEventArgs' could not be found (are you missing a using directive or an assembly reference?) [D:\a\_work\1\s\samples\dotnet\BuildAllPlayDotNet\BuildAllPlayDotNet.csproj::TargetFramework=net6.0-android]
D:\a\_work\1\s\samples\dotnet\BuildAllPlayDotNet\MainActivity.cs(16,5): error CS0246: The type or namespace name 'AssetPackStateUpdateListenerWrapper' could not be found (are you missing a using directive or an assembly reference?) [D:\a\_work\1\s\samples\dotnet\BuildAllPlayDotNet\BuildAllPlayDotNet.csproj::TargetFramework=net6.0-android]

I bet the issue is that these package versions are hardcoded:

https://github.com/xamarin/GooglePlayServicesComponents/blob/050ccd98825f036602ffb6147a1f1b98e74eaf7e/samples/dotnet/BuildAllPlayDotNet/BuildAllPlayDotNet.csproj#L37-L39

Whereas this PR bumps these versions to 2.1.0.6. We will need to do something so that these version numbers aren't hardcoded.

cc: @dellis1972

moljac commented 3 months ago

I bet the issue is that these package versions are hardcoded:

That crossed my mind, but I did not get further than build + error.

https://github.com/xamarin/GooglePlayServicesComponents/blob/050ccd98825f036602ffb6147a1f1b98e74eaf7e/samples/dotnet/BuildAllPlayDotNet/BuildAllPlayDotNet.csproj#L37-L39

Whereas this PR bumps these versions to 2.1.0.6. We will need to do something so that these version numbers aren't hardcoded.

Let me see if I can rewrite samples to use NuGet Central Package Management. We are close to it with target and props files.

moljac commented 3 months ago

closing this in favor of

https://github.com/xamarin/GooglePlayServicesComponents/pull/853