search

xamarin / SignaturePad

MIT License
245 stars 150 forks source link

Wpf and macOS #138

Open VladislavAntonyuk opened 6 years ago

msftclas commented 6 years ago

CLA assistant check
All CLA requirements met.

VladislavAntonyuk commented 6 years ago

@mattleibow Please review

mattleibow commented 6 years ago

Is there a reason you are using a pre-release of forms? I would like to avoid this if possible.

mattleibow commented 6 years ago

build

VladislavAntonyuk commented 6 years ago

I'll recheck with latest stable Xamarin forms

mattleibow commented 6 years ago

@VladislavAntonyuk looks good so far, looking forward to merging this for the world.

mattleibow commented 6 years ago

Build

VladislavAntonyuk commented 6 years ago

Could not load file or assembly 'netstandard, Version=2.0.0.0 Please add it on your CI

VladislavAntonyuk commented 6 years ago

@mattleibow do you have any objections not to merge it?

mattleibow commented 6 years ago

No, but I have been travelling and not had a chance to do a more detailed review and have a look at it running. I will be back in the office next week, so I hope to merge then.

VladislavAntonyuk commented 6 years ago

hmm, I have found an xamarin article, and as I understand we need to update build machine to .NET 4.7,1. Am I right? https://developer.xamarin.com/releases/xamarin-forms/xamarin-forms-3.0/3.0.0/

Xamarin.Forms 3.0 uses the lastest benefits of .NET Standard 2.0. To build applications with Xamarin.Forms 3.0, update your build machines to .NET 4.7.1 or greater using the Visual Studio installer. If you do not, build tasks will fail with messages like The "Xamarin.Forms.Build.Tasks.GetTasksAbi" task could not be loaded from the assembly C:\YourFolderPath\xamarin.forms\3.0.0.446417\build\netstandard2.0\Xamarin.Forms.Build.Tasks.dll. Could not load file or assembly 'netstandard, Version=2.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51' or one of its dependencies. The system cannot find the file specified.

VladislavAntonyuk commented 6 years ago

@mattleibow I have some investigations with MacOS and seems like we can support it too. Please let me know when you are ready to merge it so I can start add MacOS renderer

Mogikan commented 4 years ago

I also need this control on Mac. Anyone is alive?

VladislavAntonyuk commented 4 years ago

@Mogikan feel free to build it from my branch

adampenn commented 4 years ago

@Mogikan feel free to build it from my branch

So is this just not gonna be merged ever?

VladislavAntonyuk commented 4 years ago

Author is not responding more then 1 year. I have created my own project from scratch, which supports all platforms: Android, iOS, UWP, macOS, WPF, GTK, Tizen. This PR is a start point for everybody who wanna use GesturePad in their project

Mogikan commented 4 years ago

@VladislavAntonyuk Maybe you should make your repo primary, add description and nuget packages. It would be great. I don't like building projects from source code.

adampenn commented 4 years ago

I agree with @Mogikan, I am having problems building your code, I would love having a nuget package I can install. Is this something you are open to? I can help set up travis ci and nuget package but I am not familiar enough with this project to make it build..,

VladislavAntonyuk commented 4 years ago

Sorry, I can't provide the code which I use in my project. I will take a look at my fork and check any build issues on weekends

adampenn commented 4 years ago

@VladislavAntonyuk Can you provide me with steps to make it build? I am getting the following errors: image

VladislavAntonyuk commented 4 years ago

@adampenn I have push new changes. Make sure you have install gtk, uwp 18362, android sdk 29. I suggest you to use build.ps1 or build.sh to generate nuget package

VladislavAntonyuk commented 4 years ago

I setup CI, you can download artifacts there (see readme in my fork).