search

xamarin / Xamarin.Auth

Xamarin.Auth
Apache License 2.0
541 stars 351 forks source link

WebAuthenticatorActivity.WebClient doesn't handle page errors (Android) #287

Open ssm3ll opened 6 years ago

ssm3ll commented 6 years ago

Xamarin.Auth Issue

WebAuthenticatorActivity.WebClient for Android doesn't handle any page errors. In current version it doesn't override OnReceivedError method to pass error details to Authenticator. iOS implementation handles any page error using LoadFailed method override.

Version

Expected behaviour

Android version should handle page errors as well.

VS bug #733075

newky2k commented 6 years ago

@ssm3ll Can you please check this agains the latest version, 1.6.0.2, and if it is still happening can you provide a sample project that replicates the issue.

Regards

ssm3ll commented 6 years ago

@newky2k I still don't see OnReceiveError override method implementation here source/Core/Xamarin.Auth.XamarinIOS/PlatformSpecific/WebAuthenticatorController.UIWebView.UIWebViewDelegate.cs But iOS implementation uses LoadFailed method to pass error using controller.authenticator.OnError source/Core/Xamarin.Auth.XamarinIOS/PlatformSpecific/WebAuthenticatorController.UIWebView.UIWebViewDelegate.cs

This can be easy tested by swiping off Internet connection during oAuth page loading. iOS can easily handle loading error but not Android one

newky2k commented 6 years ago

@ssm3ll thanks for getting back to us, I'll assign this to @moljac to investigate further