search

xamarin / Xamarin.Auth

Xamarin.Auth
Apache License 2.0
541 stars 351 forks source link

Fix OAuth authenticator for Instagram authentication #350 and #360. #362

Open KevinHu-au opened 5 years ago

KevinHu-au commented 5 years ago

Xamarin.Auth Pull Request

Fixes # On ios device when loading the authentication page from Instagram, an error with "unknown_user" popup from OnPageLoaded event, because it was catching the intermediate callback from Facebook which also has 'error' url segment.

Checklist

Changes proposed in this pull request:

-

-

CoeqWEty commented 5 years ago

Hi. Kevin and all.

Hoping you can help me out. We are having the same issue. I'm running a startup and not a coder anymore, nor do I understand how issue fixes make it into Microsoft package updates. :-(.

My development team has the same issue and appears Kevin you have fixed this some how. They stated they have installed the latest Xamarin.Auth package and the issue still persists. If there is indeed a fix when will this actually make it into Xamarin.Auth available release? Does someone in Microsoft know this issue plan for release. This seems as a pretty substantial issue for cross platform development with Forms. If that release is highly uncertain what is it that they need to do to incorporate this fix from Kevin/GitHub into our package.

Thanks in advance for you help. Bob

CoeqWEty commented 5 years ago

@KevinHu-au @xamarin-release-manager Please see above question from me. Thanks Bob

jodik commented 5 years ago

I see no merge-commit since mid-January, is there a reason why this was not merged yet?

CoeqWEty commented 5 years ago

@xamarin-release-manager
Hi,

Ive reposted my Jan 31 question below on when this will be in a release of Xamarin.auth. Can you please get back to everyone. It looks like Kevin solved it. @KevinHu-au @jodik

Hoping you can help me out. We are having the same issue. I'm running a startup and not a coder anymore, nor do I understand how issue fixes make it into Microsoft package updates. :-(. My development team has the same issue and appears Kevin you have fixed this some how. They stated they have installed the latest Xamarin.Auth package and the issue still persists. If there is indeed a fix when will this actually make it into Xamarin.Auth available release? Does someone in Microsoft know this issue plan for release. This seems as a pretty substantial issue for cross platform development with Forms. If that release is highly uncertain what is it that they need to do to incorporate this fix from Kevin/GitHub into our package. Thanks in advance for you help. Bob

KevinHu-au commented 5 years ago

@econetomics Hi Bob, Sorry for missing your questions for quite a long time. I hope your team have fixed the issue.

I actually had the issue for Instagram OAuth login and took a lot of time to figure it out. I fixed this library by the pull request, but seems like I got some other issues. So my final solution for me was to handle the whole auth process by sending the auth request by Xamarin.Forms WebView, and parsing the navigating url to get the token. Basically I didn't use this library.

For Twitter login, as Twitter only support OAuth1, I did borrow lots of source code from this library.

Thanks, Kevin