Fix issue with accessing CFBoolean.TrueHandle in Xamarin.iOS 12.6 [370]

[rickykaare]

Xamarin.Auth Pull Request

Fixes #370.

Checklist

• [ ] I have included examples or tests
• [ ] I have updated the change log
• [ ] I am listed in the CONTRIBUTORS file
• [ ] I have cleaned up the commit history (use rebase and squash)

Changes proposed in this pull request:

• Use the CFBoolean.TrueHandle property in latest Xamarin.iOS and fall back to the obsolete CFBoolean.True field available in previous version of Xamarin.iOS.

In Xamarin.iOS version prior to v12.6 the CFBoolean had the True and False fields:

https://github.com/xamarin/xamarin-macios/blob/monotouch-12.4.0.64/src/CoreFoundation/CFBoolean.cs#L41-L42

These where removed in Xamarin.iOS v12.6 and replaced with the TrueHandle and FalseHandle properties:

https://github.com/xamarin/xamarin-macios/blob/monotouch-12.6.0.10/src/corefoundation.cs#L35-L41

[dnfclas]

All CLA requirements met.

[moljac]

@rickykaare

Can you provide minimal + public sample, so I can test it and verify? Please.

My time is limited (need to bump versions and release GooglePlayServices and Firebase stuff).

I will add that minimal sample to the code and test against old 1.6.0.4 nuget and new and if it is OK I will release it immediately.

Thanks

[rickykaare]

@moljac,

I was able to reproduce the error with the sample located in samples/bugs-triaging/AccountStore.

I am not sure exactly what the sample does, but the "Load" button will execute the failing FindAccountsForService function here: https://github.com/xamarin/Xamarin.Auth/blob/b4fb1bb5c409e281c6bffad74ea8caba87805ea8/samples/bugs-triaging/AccountStore/AccountStoreTest/MainPage.xaml.cs#L78-L85

The call will fail in the current release of Xamarin.Auth, but will succeeds with the suggested changes in this pull-request.

[moljac]

Thanks. Good catch for API change.

[sowmyajagar]

Is there an ETA on when this fix will be released?