Add CancellationToken parameter to RequestAccessTokenAsync

[nickl-martin]

Xamarin.Auth Pull Request

Checklist

• [ ] I have included examples or tests
• [ ] I have updated the change log
• [ ] I am listed in the CONTRIBUTORS file
• [ ] I have cleaned up the commit history (use rebase and squash)

Changes proposed in this pull request:

• Add OAuth2Authenticator.RequestAccessTokenAsync(IDictionary<string, string> queryValues, CancellationToken cancellationToken)

• Add OAuth2Authenticator.RequestAccessTokenAsync(string code, CancellationToken cancellationToken)

Adds 2 overloaded methods of OAuth2Authenticator.RequestAccessTokenAsync that include a CancellationToken parameter. The cancellation token is used in the underlying HttpClient.PostAsync call. These new overloaded methods will throw a TaskCanceledException if the token is cancelled so they should be used inside a try/catch block. These are non-breaking changes to the API.

Example Usage:

try {
    using(var cts = new CancellationTokenSource()) {
        cts.CancelAfter(5000);
        var results = await authenticator.RequestAccessTokenAsync(queryValues, cts.Token);
        return results;
    }
} catch(TaskCanceledException) {
    Debug.WriteLine("RequestAccessToken timed out after 5 seconds.");
    return null;
}

[dnfclas]

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

:x: nickl-martin sign now
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[moljac]

@nickl-martin CLA sign please...

[nick-peters-luciani]

I ended up transferring this fork this to my personal account. Do I need to make a new pull request in order to sign the CLA with this account?

[moljac]

There are 2 links (I gues for you)

• . CLA not signed
• . sign-now

I think you should visit those, sign the CLA and no new PR is needed.

OTOH I can add your code manually and close this PR.