search

xamarin / Xamarin.Auth

Xamarin.Auth
Apache License 2.0
541 stars 351 forks source link

#322, the previous implementation won't work if chrome is disabled, t… #468

Open ashotjanibekyan opened 2 years ago

ashotjanibekyan commented 2 years ago

There is no way to be sure that com.chrome.beta or com.chrome.dev is installed. Better to fetch the packages on runtime.

Xamarin.Auth Pull Request

Fixes #322 .

net-foundation-cla[bot] commented 2 years ago

CLA assistant check
All CLA requirements met.

nok3250 commented 2 years ago

You saved my day, man, thanks you a lot! Fuck Microsoft for obsoleting necessary libs! 🔥

nok3250 commented 2 years ago

image But I still have this when try to load OAuthLoginPresenter

Maybe you can write to me in a telegram https://t.me/niktemp and spend 10 minutes with me to help to resolve this? :)

ashotjanibekyan commented 2 years ago

Hi @nok3250 . This PR has not been merged yet. Did you compile it yourself or downloaded form NuGet directly?

nok3250 commented 2 years ago

Hi @nok3250 . This PR has not been merged yet. Did you compile it yourself or downloaded form NuGet directly?

I've downloaded sources and've applied your changes on them, after added Auth.Android and it's dependencies projects to my solution, and replaced nuget references with project references. They compile fine, but error occurs, on the screenshot above

nok3250 commented 2 years ago

Maybe you have .zip with compiled .dll's which work correctly on Android 12? It will be enough for me to continue to work further

Because this PR will not be merged, project is deprecated