search

xamarin / Xamarin.Legacy.Sdk

Starting from a .NET 6 project, adds the ability to target legacy Xamarin target frameworks such as monoandroid11.0 or xamarin.ios10. *Not fully supported*
MIT License
35 stars 6 forks source link

[XLS-58] fix (Xamarin.VsInstallRoot.targets): include VS2022 Community and VS2019 Community in probing #59

Closed ksidirop-laerdal closed 1 year ago

ksidirop-laerdal commented 1 year ago

@microsoft-github-policy-service agree company="Laerdal SA"

jonathanpeppers commented 1 year ago

/azp run

azure-pipelines[bot] commented 1 year ago
No pipelines are associated with this pull request.
jonathanpeppers commented 1 year ago

It looks like the build infrastructure for this repo is completely down. We'll have to wait and see when we'll be able to do another release.

bstadick commented 7 months ago

Any updates on when the release with this fix may be made?

ksidirop-laerdal commented 7 months ago

By the looks of it the latest release didn't include this PR but opted to simply probe for VS2022 instead - no idea why. But the PR seems to have gone stale and the whole project seems to be abandoned to its fate.

Kyriakos Sidiropoulos Senior Software Developer II Laerdal Medical — Stavanger, Norway ​www.laerdal.com This e-mail and any attachments thereto may contain confidential information and/or information protected by intellectual property rights for the exclusive attention of the intended addressees named above. If you have received this transmission in error, please immediately notify the sender by return e-mail and delete this message and its attachments. Unauthorized use, copying or further full or partial distribution of this e-mail or its contents is prohibited. While attachments to this e-mail are checked for viruses, Laerdal does not accept any liability for any damage caused by viruses. For more information on how we process personal data please see https://www.laerdal.com/support/customer-service/privacy-policy/ ED8rMQMmKR5nxVH

From: Bryan Stadick @.> Sent: Tuesday, March 12, 2024 10:14 PM To: xamarin/Xamarin.Legacy.Sdk @.> Cc: Kyriakos Sidiropoulos @.>; Mention @.> Subject: Re: [xamarin/Xamarin.Legacy.Sdk] [XLS-58] fix (Xamarin.VsInstallRoot.targets): include VS2022 Community and VS2019 Community in probing (PR #59)

You don't often get email from @.*** Learn why this is importanthttps://aka.ms/LearnAboutSenderIdentification

Any updates on when the release with this fix may be made?

— Reply to this email directly, view it on GitHubhttps://github.com/xamarin/Xamarin.Legacy.Sdk/pull/59#issuecomment-1992598818, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AZQS7KAR3NJS6HTCTHO3ZUDYX5V4TAVCNFSM6AAAAAA5LBDTTGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJSGU4TQOBRHA. You are receiving this because you were mentioned.Message ID: @.***>

jonathanpeppers commented 7 months ago

@ksidirop-laerdal you should either be able to set %VsInstallRoot% as an environment variable or specify it in your .csproj.

Unfortunately, it is a big job to fix our pipeline to publish real-signed builds. We have new compliance rules in the US we would need to follow. It's a lot of work for something that goes out of support on May 1, 2024.

ksidirop-laerdal commented 7 months ago

[like] Kyriakos Sidiropoulos reacted to your message:

Kyriakos Sidiropoulos Senior Software Developer II Laerdal Medical — Stavanger, Norway ​www.laerdal.com This e-mail and any attachments thereto may contain confidential information and/or information protected by intellectual property rights for the exclusive attention of the intended addressees named above. If you have received this transmission in error, please immediately notify the sender by return e-mail and delete this message and its attachments. Unauthorized use, copying or further full or partial distribution of this e-mail or its contents is prohibited. While attachments to this e-mail are checked for viruses, Laerdal does not accept any liability for any damage caused by viruses. For more information on how we process personal data please see https://www.laerdal.com/support/customer-service/privacy-policy/ ED8rMQMmKR5nxVH

From: Jonathan Peppers @.> Sent: Wednesday, March 13, 2024 1:27:14 PM To: xamarin/Xamarin.Legacy.Sdk @.> Cc: Kyriakos Sidiropoulos @.>; Mention @.> Subject: Re: [xamarin/Xamarin.Legacy.Sdk] [XLS-58] fix (Xamarin.VsInstallRoot.targets): include VS2022 Community and VS2019 Community in probing (PR #59)

You don't often get email from @.*** Learn why this is importanthttps://aka.ms/LearnAboutSenderIdentification

@ksidirop-laerdalhttps://github.com/ksidirop-laerdal you should either be able to set %VsInstallRoot% as an environment variable or specify it in your .csproj.

Unfortunately, it is a big job to fix our pipeline to publish real-signed builds. We have new compliance rules in the US we would need to follow. It's a lot of work for something that goes out of support on May 1, 2024https://dotnet.microsoft.com/platform/support/policy/xamarin.

— Reply to this email directly, view it on GitHubhttps://github.com/xamarin/Xamarin.Legacy.Sdk/pull/59#issuecomment-1994405032, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AZQS7KHXLAGIDKEJBBFQZHDYYBH3FAVCNFSM6AAAAAA5LBDTTGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJUGQYDKMBTGI. You are receiving this because you were mentioned.Message ID: @.***>