Windows error state

[ermau]

Design

• [ ] Windows
• [ ] Mac

We're not necessarily looking for a design on a per-editor basis, more of an general set of guidelines to apply whether that's a red outline, a popup, whatever.

Apply to Elements:

• [ ] String
• [ ] Bool
• [ ] Property group
• Numerics
  • [ ] Int
  • [ ] Float
  • [ ] Byte
  • Brushes
  • [ ] Brush type selector
  • [ ] Solid color editor
  • Predefined values
  • [ ] Constrained
  • [ ] Flags
  • Resource Selector
  • [ ] Filters
  • [ ] Item navigation + selection
  • Type Selector
  • [ ] Filters
  • [ ] Item navigation + selection
  • Panel
  • [ ] Property filter
  • [ ] Arrange selector
  • [ ] Group navigation/expansion
  • [ ] Property button (ctrl+space)

[vancura]

What do you think about this?

[ermau]

I think that's the wrong platform, but even aside from that there's no column to the right of the property button and I don't want to introduce one for something that should basically never be seen.

As the design doc says, in most cases we should clamp their values to valid values so the error state should be rare.

[vancura]

I think that's the wrong platform, but even aside from that there's no column to the right of the property button and I don't want to introduce one for something that should basically never be seen.

The column was there since ever just for this case, see the original specs. It's the same place we have for the Browse button (and other buttons).

This image is nearly half a year old:

[ermau]

We discussed not having that button as it moves resources interactions into two different places.

[vancura]

Ok, whatever :)

Then just put the warning icon into the textfield, right-aligned.

[BretJohnson]

Where did we end up here, on error reporting? IMO, putting the warning icon in the textfield, like @vancura suggests, is good. I'd lean toward left aligning it, though. That's what the current Android property editor does on VSMac, so left aligning is more consistent with current UX and makes the icon more visible to the user.

Also, I'd like to see this get in for 15.7, for Android. On the Android designer VSMac side it really does provide a usability benefit in several scenarios, showing useful messages. We don't have to do it for 1st preview, but I'd rather like to see it for 15.7 GA, prioritized ahead of 15.8 only proppy features. Thanks.

[vancura]

There's one problem with left-aligning (in LTR text mode, obviously): the entered text would jump based on visibility of the warning icon. Imagine you have entered a valid value, then you add a character which invalidates it – the text jumps to make space for the icon. As soon as you fix the invalid character the icon hides, and text jumps left. This would be a bad UX in my opinion.

[BretJohnson]

@vancura Yeah, it would be bad if it behaved that way. But we only validate when the user leaves the control, not on every key press, so it isn't an issue.

Here's the current Android VSMac property UI showing the warning indicator, FYI:

[BretJohnson]

And with the popup message itself showing:

[vancura]

But we only validate when the user leaves the control, not on every key press, so it isn't an issue.

Then it's fine of course.

[vancura]

Does this still need the needs-design tag?