search

xamarin / Xamarin.PropertyEditing

MIT License
24 stars 16 forks source link

[build] Ensure the pngs are copied where we expect #549

Closed alanmcgovern closed 5 years ago

alanmcgovern commented 5 years ago

This makes sure they end up in the right directory

alanmcgovern commented 5 years ago

These are the places where we end up copying the icon set to:

Xamarin.PropertyEditing.Mac/bin/Debug/PropertyEditingResource.bundle
Xamarin.PropertyEditing.Mac.Standalone/obj/Debug/actool/bundle
Xamarin.PropertyEditing.Mac.Standalone/bin/Debug/Xamarin.PropertyEditing.Mac.Standalone.app/Contents/MonoBundle/PropertyEditingResource.bundle
Xamarin.PropertyEditing.Mac.Standalone/bin/Debug/PropertyEditingResource.bundle

This looks good as it's in the right location in the appbundle and was appropriately local copied to the output directory of the project which references Xamarin.PropertyEditing.Mac

CartBlanche commented 5 years ago

@alanmcgovern Looks good and works for Standalone. So will that also work once we bump Jose's PR (https://github.com/mono/monodevelop/pull/6742) for him, based on the previous build changes?

alanmcgovern commented 5 years ago

Yup! It should make the changes in jose's branch unnecessary.

The only gotcha is that Xamarin.Mac based projects do not take transitive Content files into account when generating the final appbundle, which they should. That's why xamarin.mac executable projects still need to manually copy the bundle from their output dir inside the app bundle dir.