xamarin / Xamarin.PropertyEditing

MIT License
24 stars 16 forks source link

[Mac] Handle tabbing into the NSOutlineView #578

Closed alanmcgovern closed 5 years ago

alanmcgovern commented 5 years ago

Fixes - https://github.com/xamarin/Xamarin.PropertyEditing/issues/510 If the outline view is made the first responder we should select the first row (if there's no selection) and then we should make it the first responder.

alanmcgovern commented 5 years ago

@CartBlanche this only helps when tabbing forward

CartBlanche commented 5 years ago

@alanmcgovern It looks to me like when trying to reverse tab, back to the propertySearch that the BecomeFirstResponder code it reseting the focus. I'm will also investigate (after the Binding changes) a ghost tab, if the propertyList is empty. Definitely MUCH better than what we currently have.

CartBlanche commented 5 years ago

Current Tabbing. Single out of PropertyFilter.

Click to see video...

Tabbing Example
CartBlanche commented 5 years ago

@ermau, @alanmcgovern Please either take a look at the code or watch the video link above. If you tab forwards all the way to the end, it single tabs correctly all the way through the PropertyList and the PropertyFilter and round again. The only glitch is having to double tab backwards from the very 1st control of the PropertyList back to the PropertyFilter control. So we're 98% of the way there. It is about 1000% better than what we currently have, as tabbing right now doesn't work at all.

CartBlanche commented 5 years ago

Added a new issue referring to the double back tab from the PropertyPanel - https://github.com/xamarin/Xamarin.PropertyEditing/issues/589