Move ViewDidChangeEffectiveAppearance calls

xamarin / Xamarin.PropertyEditing

MIT License

24 stars 16 forks source link

Move ViewDidChangeEffectiveAppearance calls #587

Closed ermau closed 5 years ago

ermau commented 5 years ago

We need to move our effective appearance calls to a second method that we can call from the ctor and an override.

CartBlanche commented 5 years ago

@ermau I see how this will fix the immediate bug of ViewDidChangeEffectiveAppearance being called on OSes that don't have that call, but how will we notify the views of an Appearance change on those older OSes? AFAICT, the previous mechanism has been removed.

ermau commented 5 years ago

It won't, we can't support live theme changes on prior OS

CartBlanche commented 5 years ago

@ermau couldn't we have had a system that fell back to the previous (or better version of) mechanism on prior OSes, and uses the new one on OSes that support it?