Open ermau opened 5 years ago
@vancura Can we get some color guidance on this control for light/dark themes? We're moving over the original but it was not themed.
There are a couple of issues, especially in different spaces around the inner rectangle, lengths of each line and mainly about stroke width (it's centered 1pt
and hence antialiased, semi-transparent). I'd like to properly design this editor, do we have time?
@vancura Only if you can get it to me this week and it doesn't represent a huge departure. I'll address the spacing issues, I just wanted to get a photo off to you to hopefully get some colors back quickly.
What do you think about this?
Unfortunately we don't have the Autoresizing and Origin colors in the ColorService
library, you'll need to create them in code or add new tokens.
Thanks!
@vancura looks good to me, thanks!
@vancura That looks good! We also need colours for when the control is disabled? ATM I'm converting the "active" colours (the reds) to gray (different to your aforementioned grays) and leaving the rest as is. Looks ok, but something more inline with your design would be better, IMO.
The standard way is to make the control 50% opacity when disabled. Can you test this? I think that should be fine.