search

xamarin / Xamarin.PropertyEditing

MIT License
24 stars 16 forks source link

Adds a new mechanism to open Modal dialogs over VS4Mac context #738

Closed netonjm closed 4 years ago

netonjm commented 4 years ago

This issue was hitting some problems. Use NSApplication.SharedApplication.RunModalForWindow (window) over a GTK application has very odd behaviours with our hacks. In this case, it sets null the current NSApplication.SharedApplciation.MainWindow, and that's the reason because the focused ring is not visible and not receiving the keyevents.

Additional to this, the IDE has a default behaviour of focus the Document selected when it gets the focus, and this behaviour it was executed after the Proppy call. That's because now we wait until SynchronizationContext to execute our proppy focus call.

v6G5ysrIob

The fix doesn't breaks the Standalone

yh08ZMuOVJ

Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1002094

garuma commented 4 years ago

🤯, I'm gonna need a bit of time to understand the logic

CartBlanche commented 4 years ago

@netonjm @garuma Hope the above suggested changes make sense. If not I can submit a commit. Let me know either way.

CartBlanche commented 4 years ago

@netonjm Let me know if the new commit is ok and works for you too?

netonjm commented 4 years ago

sounds good, could you please verify it? I'm working in another stuff

CartBlanche commented 4 years ago

@netonjm I tested in Proppy and in VsMac and appears to work. But just to be safe it would be nice to have someone else play with it. I'm a terrible tester :p