search

xamarin / Xamarin.PropertyEditing

MIT License
24 stars 16 forks source link

Bump provisioned dependencies #766

Closed BretJohnson closed 3 years ago

BretJohnson commented 3 years ago

Bump provisioned dependencies to match what's currently used for Designer, getting the latest Xamarin.Mac.

This is needed because the Xamarin.Mac.dll path changed and we need to update the csproj reference to it accordingly, also done here.

decriptor commented 3 years ago

I'm not sure why this built and worked, but things like this have to be changed: https://github.com/xamarin/Xamarin.PropertyEditing/blob/1fd6c0b7f1221222bc93d0d509e267c64e19cb45/Xamarin.PropertyEditing.Mac/Xamarin.PropertyEditing.Mac.csproj

changed: <MacFile Include="/Library/Frameworks/Xamarin.Mac.framework/Versions/Current/lib/x86_64/full/Xamarin.Mac.dll"/> to: <MacFile Include="/Library/Frameworks/Xamarin.Mac.framework/Versions/Current/lib/64bits/full/Xamarin.Mac.dll"/>

The path is new 64bits instead of x86_64

BretJohnson commented 3 years ago

@decriptor Yeah, I meant to update that. Thx. Fixed.

decriptor commented 3 years ago

@BretJohnson no worries. I've been dealing with it a bunch lately so it is on the top of my mind :) The other slightly older change was the location of libxammac.dylib, but I don't think it is referenced in here.

BretJohnson commented 3 years ago

@mcumming And now the build fails, since the agent's installed VSMac doesn't have the latest Xamarin.Mac and we don't provision. Should we update to use different YAML, that does provisioning? Can you make that change?

BretJohnson commented 3 years ago

@mcumming - ping on this

decriptor commented 3 years ago

Closing in favor of #767