[d17-0-vsmac] Fixed NSColor dispose side effect.

xamarin / Xamarin.PropertyEditing

MIT License

24 stars 16 forks source link

[d17-0-vsmac] Fixed NSColor dispose side effect. #788

Closed vs-mobiletools-engineering-service2 closed 2 years ago

vs-mobiletools-engineering-service2 commented 2 years ago

Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1455310 Bug 1455310: [Feedback] Editor theme is not correctly updated when the theme changes (VS for Mac 2022 Preview 4)

Backport of #787

BretJohnson commented 2 years ago

Note that the CI build failures here are apparently caused by the AzDO hosted macOS-latest image upgrading to a new version of VSMac 8 and also updating the default xcode from 13.1 to 13.2.1. It looks like that changed about a week ago, breaking things. I'll work on fixing that in a separate PR, but this code change didn't have anything to do with it.