Reimplementation UpdateKeyViews() based in ProxyRowResponder

netonjm commented 2 years ago

[x] Fixes NRE trying BecomeFirstResponder when GetRow gets a null object (probably a race condition reloading)
[x] Reimplements hack to set first responder based in _primitiveSetDefaultNextKeyView

The old approach was doing a recusive iteration on every editor multiple times re-configuring next responder in any focus change, which was complicated to maintain/understand and dowhile{} was giving us unexpected results (Infinite loops).

To try improve how focus is handled over this views, now we only calculate the next/previous responder "on demand", when tab or shift+tab is pressed in a specific view implementing a ProxyRowResponder which knows if is first/end view and moves to the next available editor.

Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1472832

BretJohnson commented 2 years ago

@gitbot backport main

vs-mobiletools-engineering-service2 commented 2 years ago

Backport Job to branch main Created! The magic is happening here

vs-mobiletools-engineering-service2 commented 2 years ago

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=5816510 for more details.

xamarin / Xamarin.PropertyEditing

Reimplementation UpdateKeyViews() based in ProxyRowResponder #792