search

xamarin / Xamarin.PropertyEditing

MIT License
24 stars 16 forks source link

Remove UpdateExpansions #812

Closed BretJohnson closed 2 years ago

BretJohnson commented 2 years ago

Remove the call to UpdateExpansions after ReloadData in response to OnPropertiesChanged (e.g. called when selection changes). This doesn't seem necessary, as when views are recreated their expansion status is set correctly originally and AppKit remembers expansion state after.

Further, this fixes AB#1521131, where the Name and Type rows are sometimes blank - apparently expanding manually, and doing it synchronously like that, causes the NSOutlineView to get confused and not show the top row sometimes.

BretJohnson commented 2 years ago

@gitbot backport main

vs-mobiletools-engineering-service2 commented 2 years ago

Backport Job to branch main Created! The magic is happening here

vs-mobiletools-engineering-service2 commented 2 years ago

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6043502 for more details.