search

xamarin / Xamarin.PropertyEditing

MIT License
24 stars 16 forks source link

Allow other NuGet feeds when building #828

Closed mrward closed 1 year ago

mrward commented 1 year ago

When using the latest internal .NET SDK the build will fail since Xamarin.PropertyEditing cannot resolve the latest packages since all internal package sources are cleared. Resulting in a build failure:

error NU1102: Unable to find package Microsoft.NETCore.App.Ref with version (= 6.0.14)
mrward commented 1 year ago

Also needs backporting to main.

BretJohnson commented 1 year ago

@mrward (cc @netonjm ) - This LGTM. Assuming this is definitely needed for VSMac 17.5, feel free to merge it and then do a submodule bump in vsmac release-17.5 As for main, I merged it and I'm bumping the submodule there (which was also needed to get another 17.6 fix): https://github.com/xamarin/vsmac/pull/9975

mrward commented 1 year ago

It can wait for a bit, have tagged as do-not-merge. It is being used in this other VS Mac PR for 17.5 which is not going to be merged for a while - https://github.com/xamarin/vsmac/pull/9970

mcumming commented 1 year ago

Closing since https://github.com/xamarin/vsmac/pull/9970 has been closed.