Implement saving and deleting accounts

xamarin / Xamarin.Social

Xamarin.Social

Apache License 2.0

123 stars 74 forks source link

Implement saving and deleting accounts #14

Closed gaearon closed 10 years ago

gaearon commented 11 years ago

DeleteAccount implements logging out. Our use case for SaveAccount is when your token gets expired, and you need to save the account with an updated token.

Xamarin.Auth is bumped to the version that contains AccountStore.Delete. Commit licensed under MIT/X11

ermau commented 11 years ago

I don't think we really need a SupportsSave and a SupportsDelete, do we? Not much point in being able to save an account that you can't later delete.

gaearon commented 11 years ago

@ermau Fixed now. I only left SupportsSave. Can you please take another look?

ermau commented 10 years ago

Remove the Xamarin.Auth submodule change and I will merge this.

gaearon commented 10 years ago

@ermau

I squashed my changes and force-pushed the update.

Removed submodule change
Changed SaveAccount/DeleteAccount to accept the more generic Android.Content.Context instead of Android.App.Activity. This is the type AccountStore wants. I've heard from Android folks it's better to avoid passing the Activity around because it might get captured somewhere, leading to memory leaks, whereas passing e.g. Android.App.Application.Context would do just fine in this case.