xamarin / XamarinCommunityToolkit

The Xamarin Community Toolkit is a collection of Animations, Behaviors, Converters, and Effects for mobile development with Xamarin.Forms. It simplifies and demonstrates common developer tasks building iOS, Android, and UWP apps with Xamarin.Forms.
MIT License
1.58k stars 471 forks source link

[Bug] UWP Popup dismiss triggers light dismiss #1194

Open chowarth opened 3 years ago

chowarth commented 3 years ago

Description

When closing a popup on UWP using the Dismiss method the LightDismiss method is also invoked.

Steps to Reproduce

  1. Open Xamarin.Community.Toolkit.Sample solution
  2. Open the PopupRenderer.uwp.cs file and add a breakpoint at line 263: Element.LightDismiss();
  3. Set the UWP project as the startup project
  4. Run the sample app
  5. Under Views > Popup, select Popup with 1 Button
  6. Tap the OKAY button to dismiss the popup

Expected Behavior

The breakpoint on line 263 will not be hit and continuing execution will not invoke LightDismiss.

Actual Behavior

The breakpoint on line 263 will be hit and continuing execution will invoke LightDismiss.

Basic Information

Workaround

None found

Potential Solution

SkyeHoefling commented 3 years ago

I think this might be fixed in #1362. I noticed there was some odd behaviors around light dismiss vs regular dismiss and I added some code to resolve these problems. @chowarth can you take a look at the PR or pull it down and see if it is fixed there

chowarth commented 3 years ago

@ahoefling it does appear to have been fixed by #1362 👍🏼