[Bug] UWP Popup dismiss triggers light dismiss

[chowarth]

Description

When closing a popup on UWP using the Dismiss method the LightDismiss method is also invoked.

Steps to Reproduce

1. Open Xamarin.Community.Toolkit.Sample solution
2. Open the PopupRenderer.uwp.cs file and add a breakpoint at line 263: Element.LightDismiss();
3. Set the UWP project as the startup project
4. Run the sample app
5. Under Views > Popup, select Popup with 1 Button
6. Tap the OKAY button to dismiss the popup

Expected Behavior

The breakpoint on line 263 will not be hit and continuing execution will not invoke LightDismiss.

Actual Behavior

The breakpoint on line 263 will be hit and continuing execution will invoke LightDismiss.

Basic Information

• Version with issue: 1.1.0
• Last known good version: N/A
• IDE: Visual Studio 2019 16.9.3
• Platform Target Frameworks:
  • UWP: TargetVersion=19041, MinVersion=17763
• Nuget Packages:
  • Xamarin.CommunityToolkit 1.1.0
  • Xamarin.Forms 5.0.0.2012
  • Xamarin.Essentials.Interfaces 1.6.1
• Affected Devices:
  • UWP Desktop

Workaround

None found

Potential Solution

• Add an isDismissing flag
• Set to true before Hide is invoked
• Set to false after Hide is invoked
• Add an additional check in OnClosing to ensure that Element.LightDismiss() is only invoked when isDismissing is false

[SkyeHoefling]

I think this might be fixed in #1362. I noticed there was some odd behaviors around light dismiss vs regular dismiss and I added some code to resolve these problems. @chowarth can you take a look at the PR or pull it down and see if it is fixed there

[chowarth]

@ahoefling it does appear to have been fixed by #1362 👍🏼