xamarin / XamarinCommunityToolkit

The Xamarin Community Toolkit is a collection of Animations, Behaviors, Converters, and Effects for mobile development with Xamarin.Forms. It simplifies and demonstrates common developer tasks building iOS, Android, and UWP apps with Xamarin.Forms.
MIT License
1.59k stars 472 forks source link

fix TabViewIndicator position on RTL #1983

Closed Tarekka closed 5 months ago

Tarekka commented 1 year ago

Description of Bug

TabView - TabViewIndicator goes off the screen when flow direction is RTL. This is caused by the UpdateTabIndicatorPosition method not taking RTL into consideration when calculating the position to translate the indicator to.

Issues Fixed

Behavioral Changes

PR Checklist

jfversluis commented 5 months ago

Now that we're so close to the sunsetting of Xamarin (and therefore also Xamarin Community Toolkit) unfortunately we won't be able to take this in anymore, we're really sorry about that. Nevertheless, thank you so much for your time and effort that you have put into this PR, we really appreciate it.

Please have a look at the evolution of the Xamarin Community Toolkit, The .NET MAUI Community Toolkit. A lot of development has been going on there. Hopefully this issue was already fixed in that codebase. If not, feel free to port this over to there.

Again, thank you so much for being a contributor and Xamarin user!