search

xamarin / XamarinComponents

Plugins for Xamarin
MIT License
1.99k stars 695 forks source link

Update SDWebImage to 5.11.1 #1263

Open eman1986 opened 2 years ago

eman1986 commented 2 years ago

looks like SDWebImage 5 has some much improved code to handle things like animated images, also the current bindings is 2 years old. I'd be happy to help if I knew how you guys made the current bindings.

eman1986 commented 2 years ago

I found an older ticket that looks to have explained it in some way, I'll give it a shot and see if I can get this updated to the latest version.

eman1986 commented 2 years ago

with their newest version, they now have coders for more complex image formats, should I build that into this nuget as well as should that be saved for their own nuget package from the community?

eman1986 commented 2 years ago

I've finally gotten to it but when I run the cake script I get some errors:

/Users/ed/git/XamarinComponents/iOS/SDWebImage/build.cake(9,11): error CS0103: The name 'CocoaPodVersion' does not exist in the current context /Users/ed/git/XamarinComponents/iOS/SDWebImage/build.cake(34,2): error CS0103: The name 'CocoaPodInstall' does not exist in the current context /Users/ed/git/XamarinComponents/iOS/SDWebImage/build.cake(34,50): error CS0246: The type or namespace name 'CocoaPodInstallSettings' could not be found (are you missing a using directive or an assembly reference?) /Users/ed/git/XamarinComponents/iOS/SDWebImage/build.cake(101,35): error CS1503: Argument 2: cannot convert from 'bool' to 'Cake.Common.IO.DeleteDirectorySettings' /Users/ed/git/XamarinComponents/common.cake(44,4): error CS0103: The name 'XCodeBuild' does not exist in the current context /Users/ed/git/XamarinComponents/common.cake(44,19): error CS0246: The type or namespace name 'XCodeBuildSettings' could not be found (are you missing a using directive or an assembly reference?) /Users/ed/git/XamarinComponents/common.cake(91,4): error CS0103: The name 'XCodeBuild' does not exist in the current context /Users/ed/git/XamarinComponents/common.cake(91,19): error CS0246: The type or namespace name 'XCodeBuildSettings' could not be found (are you missing a using directive or an assembly reference?) /Users/ed/git/XamarinComponents/common.cake(136,4): error CS0103: The name 'XCodeBuild' does not exist in the current context /Users/ed/git/XamarinComponents/common.cake(136,19): error CS0246: The type or namespace name 'XCodeBuildSettings' could not be found (are you missing a using directive or an assembly reference?) /Users/ed/git/XamarinComponents/common.cake(179,4): error CS0103: The name 'XCodeBuild' does not exist in the current context /Users/ed/git/XamarinComponents/common.cake(179,20): error CS0246: The type or namespace name 'XCodeBuildSettings' could not be found (are you missing a using directive or an assembly reference?) /Users/ed/git/XamarinComponents/common.cake(241,4): error CS0103: The name 'XCodeBuild' does not exist in the current context /Users/ed/git/XamarinComponents/common.cake(241,20): error CS0246: The type or namespace name 'XCodeBuildSettings' could not be found (are you missing a using directive or an assembly reference?)

eman1986 commented 2 years ago

I've created a PR for this: https://github.com/xamarin/XamarinComponents/pull/1275