search

xamarin / urho

Code to integrate with the Urho3D engine
Other
464 stars 122 forks source link

UrhoSharp.Forms.dll should depend UrhoSharp.dll not UrhoShap shared #166

Open rdpeake opened 7 years ago

rdpeake commented 7 years ago

By having urho Forms as a standalone DLL it is impossible to embed apps made for UrhoSharp into forms apps and vice versa. however, if the UrhoSharp.forms only contained the Urho.Forms namespace and depended on UrhoSharp for the rest, this would not be an issue.

EgorBo commented 7 years ago

@rdpeake makes sense, I actually have already done it in my local branch.

EgorBo commented 7 years ago

It has a lot of issues, as a workaround - you can use Shared Project between UrhoSharp.Forms and UrhoSharp projects.

rdpeake commented 7 years ago

Hey, can you tell me what those problems are, as i'm currently running my own version of Urho.Forms as i needed to make some changes (as seen in a pull request by myself as well). This seems to be working for me, have i just been lucky?