[dotnet] P4 runtime issue tracking

spouliot commented 3 years ago

Updating from P3

PR#11127

Microsoft.Dotnet.Sdk.Internal: from 6.0.100-preview.3.21202.5 to 6.0.100-preview.4.21207.50
- Several tests failures -> merge ~BLOCKED~

Fixes

PR#11173 [dotnet][msbuild] Fix RelativePath inside ResolvedFileToPublish
PR#11182 Bump MSBuild.StructuredLogger to 2.1.404

PR was automatically merged (CI error since it has not run the tests) -> reverted

PR#11175

Microsoft.Dotnet.Sdk.Internal: from 6.0.100-preview.3.21202.5 to 6.0.100-preview.4.21215.1
- Most failures seems related to linker Copy changes -> seems fixed by a later bump (likely the one that included https://github.com/mono/linker/commit/7f7eb298a1ea6a144b2fb795ca10feb138e3988a)
From Version 6.0.100-preview.3.21202.5 -> To Version 6.0.100-preview.4.21214.14
- ~~Update Mono package names~~ thanks @pjcollins for heads up
- ~~build failures (on CI) due to missing libicudata.a~~ -> fix
- ~~app builds fails for missing symbols hiding previous link sdk issue~~ -> fix
- ~~linker not working (tests seems fine) leading to huge app size and build times~~ -> fix
- monotouch-tests timeout happened on the last 3 runs
- seems TimeZone / ICU related -> @filipnavara filled both https://unicode-org.atlassian.net/browse/ICU-21591 and https://github.com/unicode-org/icu/pull/1699 -> introduced with https://github.com/dotnet/runtime/pull/48931 -> workaound
- ~~non-dotnet tests also failed - but they started to work again once the test timing out was ignored (that likely cause an issue on bots)~~
- ~~coreclr runtime for Mac is not downloaded anymore - but there's no build failures~~ -> fix
- ~~more path issues affecting satellite assemblies likely similar to #11173 above~~ -> fix

PR#11175 was merged in main and became the base for release/6.0.1xx-preview4

Keeping issue open as we can get more P4 bumps (in both branches)

PR#11314 unmerged, blocked by test failures MERGED

~~MSBuild tests/Integration: Failed (Execution failed with exit code 32)~~
- Multiple ArgumentNullException failures for Xamarin.iOS.Tasks.DotNetTest
- Requires a newer MSBuild.StructuredLogger (2.1.472), waiting for it to be available on our feed
- Fix https://github.com/xamarin/xamarin-macios/pull/11314/commits/4a31e75dce90468f0c641dc920a96c62ac715386

PR#11426 MERGED

merged

PR#11443

building...

spouliot commented 3 years ago

app builds fails for missing symbols hiding previous link sdk issue

The native libraries are not copied into obj so they are not linked to the final executable - so we're left with undefined symbols, which breaks the build.

On preview 4

09:29:32.6206100                              /Users/poupou/git/main/xamarin-macios/tests/dotnet/packages/microsoft.netcore.app.runtime.mono.iossimulator-x64/6.0.0-preview.4.21213.3/runtimes/iossimulator-x64/native/libSystem.Net.Security.Native.a
09:29:32.6206150                                      AssemblyVersion=
09:29:32.6206320                                      AssetType=native
09:29:32.6206380                                      CopyLocal=true
09:29:32.6206420                                      DestinationSubPath=libSystem.Net.Security.Native.a
09:29:32.6206470                                      DropFromSingleFile=true
09:29:32.6206520                                      FileVersion=0.0.0.0
09:29:32.6206560                                      IsTrimmable=true
09:29:32.6206620                                      NuGetPackageId=Microsoft.NETCore.App.Runtime.Mono.iossimulator-x64
09:29:32.6206660                                      NuGetPackageVersion=6.0.0-preview.4.21213.3
09:29:32.6206710                                      PublicKeyToken=
09:29:32.6206760                                      RuntimeIdentifier=iossimulator-x64

On preview 3

DropFromSingleFile=
IsTrimmable=

Fixed with https://github.com/xamarin/xamarin-macios/pull/11175/commits/106defd7ae065a40bb32356c19f00d4197b39c87

rolfbjarne commented 3 years ago

@spouliot any reason we can't close this now? P4 should be good to go.

spouliot commented 3 years ago

@rolfbjarne waiting for the public release, just in case a last minute bump was requested

spouliot commented 3 years ago

https://devblogs.microsoft.com/dotnet/announcing-net-6-preview-4/

xamarin / xamarin-macios