xamarin / xamarin-macios

.NET for iOS, Mac Catalyst, macOS, and tvOS provide open-source bindings of the Apple SDKs for use with .NET managed languages such as C#

Other

2.45k stars 511 forks source link

[AudioUnit] Remove unnecessary MarshalAs attributes from the AudioComponentDescription struct. #20565

Closed rolfbjarne closed 5 months ago

rolfbjarne commented 5 months ago

This makes any P/Invokes that uses this struct have a blittable signature.

Contributes towards #15684.

vs-mobiletools-engineering-service2 commented 5 months ago

:fire: [PR Build] Build failed :fire:

Build failed for the job 'Build packages'

Pipeline on Agent Hash: cd4c1866f72b066a77dbcc6a8817d40f0736a8c9 [PR build]

vs-mobiletools-engineering-service2 commented 5 months ago

:fire: [PR Build] Build failed :fire:

Build failed for the job 'Detect API changes'

Pipeline on Agent Hash: cd4c1866f72b066a77dbcc6a8817d40f0736a8c9 [PR build]

vs-mobiletools-engineering-service2 commented 5 months ago

:computer: [PR Build] Tests on macOS X64 - Mac Sonoma (14) passed :computer:

:white_check_mark: All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent Hash: [PR build]

vs-mobiletools-engineering-service2 commented 5 months ago

:computer: [PR Build] Tests on macOS M1 - Mac Monterey (12) passed :computer:

:white_check_mark: All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent Hash: [PR build]

vs-mobiletools-engineering-service2 commented 5 months ago

:computer: [PR Build] Tests on macOS M1 - Mac Ventura (13) passed :computer:

:white_check_mark: All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent Hash: [PR build]

vs-mobiletools-engineering-service2 commented 5 months ago

:computer: [PR Build] Tests on macOS M1 - Mac Big Sur (11) passed :computer:

:white_check_mark: All tests on macOS M1 - Mac Big Sur (11) passed.

Pipeline on Agent Hash: [PR build]

vs-mobiletools-engineering-service2 commented 5 months ago

:fire: [CI Build] Test results :fire:

Test results

:x: Tests failed on VSTS: test results

26 tests crashed, 0 tests failed, 0 tests passed.

Failures

:x: cecil tests

:fire: Failed catastrophically on VSTS: test results - cecil (no summary found).

Html Report (VSDrops) Download

:x: dotnettests tests (iOS)

:fire: Failed catastrophically on VSTS: test results - dotnettests_ios (no summary found).

Html Report (VSDrops) Download

:x: dotnettests tests (MacCatalyst)

:fire: Failed catastrophically on VSTS: test results - dotnettests_maccatalyst (no summary found).

Html Report (VSDrops) Download

:x: dotnettests tests (macOS)

:fire: Failed catastrophically on VSTS: test results - dotnettests_macos (no summary found).

Html Report (VSDrops) Download

:x: dotnettests tests (Multiple platforms)

:fire: Failed catastrophically on VSTS: test results - dotnettests_multiple (no summary found).

Html Report (VSDrops) Download

:x: dotnettests tests (tvOS)

:fire: Failed catastrophically on VSTS: test results - dotnettests_tvos (no summary found).

Html Report (VSDrops) Download

:x: framework tests

:fire: Failed catastrophically on VSTS: test results - framework (no summary found).

Html Report (VSDrops) Download

:x: fsharp tests

:fire: Failed catastrophically on VSTS: test results - fsharp (no summary found).

Html Report (VSDrops) Download

:x: generator tests

:fire: Failed catastrophically on VSTS: test results - generator (no summary found).

Html Report (VSDrops) Download

:x: install-source tests

:fire: Failed catastrophically on VSTS: test results - install-source (no summary found).

Html Report (VSDrops) Download

:x: interdependent-binding-projects tests

:fire: Failed catastrophically on VSTS: test results - interdependent-binding-projects (no summary found).

Html Report (VSDrops) Download

:x: introspection tests

:fire: Failed catastrophically on VSTS: test results - introspection (no summary found).

Html Report (VSDrops) Download

:x: linker tests

:fire: Failed catastrophically on VSTS: test results - linker (no summary found).

Html Report (VSDrops) Download

:x: mac-binding-project tests

:fire: Failed catastrophically on VSTS: test results - mac-binding-project (no summary found).

Html Report (VSDrops) Download

:x: mmp tests

:fire: Failed catastrophically on VSTS: test results - mmp (no summary found).

Html Report (VSDrops) Download

:x: mononative tests

:fire: Failed catastrophically on VSTS: test results - mononative (no summary found).

Html Report (VSDrops) Download

:x: monotouch tests (iOS)

:fire: Failed catastrophically on VSTS: test results - monotouch_ios (no summary found).

Html Report (VSDrops) Download

:x: monotouch tests (MacCatalyst)

:fire: Failed catastrophically on VSTS: test results - monotouch_maccatalyst (no summary found).

Html Report (VSDrops) Download

:x: monotouch tests (macOS)

:fire: Failed catastrophically on VSTS: test results - monotouch_macos (no summary found).

Html Report (VSDrops) Download

:x: monotouch tests (tvOS)

:fire: Failed catastrophically on VSTS: test results - monotouch_tvos (no summary found).

Html Report (VSDrops) Download

:x: monotouch tests (watchOS)

:fire: Failed catastrophically on VSTS: test results - monotouch_watchos (no summary found).

Html Report (VSDrops) Download

:x: msbuild tests

:fire: Failed catastrophically on VSTS: test results - msbuild (no summary found).

Html Report (VSDrops) Download

:x: mtouch tests

:fire: Failed catastrophically on VSTS: test results - mtouch (no summary found).

Html Report (VSDrops) Download

:x: xammac tests

:fire: Failed catastrophically on VSTS: test results - xammac (no summary found).

Html Report (VSDrops) Download

:x: xcframework tests

:fire: Failed catastrophically on VSTS: test results - xcframework (no summary found).

Html Report (VSDrops) Download

:x: xtro tests

:fire: Failed catastrophically on VSTS: test results - xtro (no summary found).

Html Report (VSDrops) Download

Successes

Pipeline on Agent Hash: [PR build]

vs-mobiletools-engineering-service2 commented 5 months ago

:computer: [PR Build] Tests on macOS X64 - Mac Sonoma (14) passed :computer:

:white_check_mark: All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent Hash: [PR build]

vs-mobiletools-engineering-service2 commented 5 months ago

:computer: [PR Build] Tests on macOS M1 - Mac Ventura (13) passed :computer:

:white_check_mark: All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent Hash: [PR build]

vs-mobiletools-engineering-service2 commented 5 months ago

:computer: [PR Build] Tests on macOS M1 - Mac Monterey (12) passed :computer:

:white_check_mark: All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent Hash: [PR build]

vs-mobiletools-engineering-service2 commented 5 months ago

:computer: [PR Build] Tests on macOS M1 - Mac Big Sur (11) passed :computer:

:white_check_mark: All tests on macOS M1 - Mac Big Sur (11) passed.

Pipeline on Agent Hash: [PR build]

vs-mobiletools-engineering-service2 commented 5 months ago

:books: [PR Build] Artifacts :books:

Packages generated

View packages

* [xamarin.ios-17.3.0.414.pkg](https://dl.internalx.com/wrench/merge/fc67d01d3a606aedf634546e69d607e614d53e9d/9533219/package/xamarin.ios-17.3.0.414.pkg) * [xamarin.mac-9.3.0.414.pkg](https://dl.internalx.com/wrench/merge/fc67d01d3a606aedf634546e69d607e614d53e9d/9533219/package/xamarin.mac-9.3.0.414.pkg)

Pipeline on Agent Hash: [PR build]

vs-mobiletools-engineering-service2 commented 5 months ago

:computer: [CI Build] Windows Integration Tests passed :computer:

:white_check_mark: All Windows Integration Tests passed.

Pipeline on Agent Hash: 8a8a05e312dbdffd5b0cce29858e60e162241f56 [PR build]

vs-mobiletools-engineering-service2 commented 5 months ago

:white_check_mark: API diff for current PR / commit

Legacy Xamarin (No breaking changes)

* iOS: [vsdrops](https://vsdrop.corp.microsoft.com/file/v1/xamarin-macios/detected-changes/20240506.13/9533219-1/;/previous-api-comparison/ios-api-diff.html) [gist](https://gist.github.com/vs-mobiletools-engineering-service2/de6bab4669c6f4ec67b4231b8a87be1c) (No breaking changes) * tvOS: [vsdrops](https://vsdrop.corp.microsoft.com/file/v1/xamarin-macios/detected-changes/20240506.13/9533219-1/;/previous-api-comparison/tvos-api-diff.html) [gist](https://gist.github.com/vs-mobiletools-engineering-service2/ef559ac31b22d70ea8e393cfcdba5298) (No breaking changes) * ~watchOS~ (no change detected) * macOS: [vsdrops](https://vsdrop.corp.microsoft.com/file/v1/xamarin-macios/detected-changes/20240506.13/9533219-1/;/previous-api-comparison/mac-api-diff.html) [gist](https://gist.github.com/vs-mobiletools-engineering-service2/176e33eedb763935ead4ac84e8e30ceb) (No breaking changes)

.NET (No breaking changes)

* iOS: [vsdrops](https://vsdrop.corp.microsoft.com/file/v1/xamarin-macios/detected-changes/20240506.13/9533219-1/;/previous-api-comparison/diff/dotnet/Microsoft.iOS.Ref/ref/net8.0/Microsoft.iOS.html) [gist](https://gist.github.com/vs-mobiletools-engineering-service2/dca28eb084f59628c6ebadf621c18472) (No breaking changes) * tvOS: [vsdrops](https://vsdrop.corp.microsoft.com/file/v1/xamarin-macios/detected-changes/20240506.13/9533219-1/;/previous-api-comparison/diff/dotnet/Microsoft.tvOS.Ref/ref/net8.0/Microsoft.tvOS.html) [gist](https://gist.github.com/vs-mobiletools-engineering-service2/9d23bf1259c9972df1d2a6553d3917bc) (No breaking changes) * MacCatalyst: [vsdrops](https://vsdrop.corp.microsoft.com/file/v1/xamarin-macios/detected-changes/20240506.13/9533219-1/;/previous-api-comparison/diff/dotnet/Microsoft.MacCatalyst.Ref/ref/net8.0/Microsoft.MacCatalyst.html) [gist](https://gist.github.com/vs-mobiletools-engineering-service2/37dbdf68c5db4f4fb19700031547fccf) (No breaking changes) * macOS: [vsdrops](https://vsdrop.corp.microsoft.com/file/v1/xamarin-macios/detected-changes/20240506.13/9533219-1/;/previous-api-comparison/diff/dotnet/Microsoft.macOS.Ref/ref/net8.0/Microsoft.macOS.html) [gist](https://gist.github.com/vs-mobiletools-engineering-service2/823236a90866f1e5cde26cb913779164) (No breaking changes)

:white_check_mark: API diff vs stable

Legacy Xamarin (No breaking changes)

* iOS: [vsdrops](https://vsdrop.corp.microsoft.com/file/v1/xamarin-macios/detected-changes/20240506.13/9533219-1/;/stable-api-comparison/ios-api-diff.html) [gist](https://gist.github.com/vs-mobiletools-engineering-service2/739ec979d3da6c9dc787d43c3d39f69a) (No breaking changes) * tvOS: [vsdrops](https://vsdrop.corp.microsoft.com/file/v1/xamarin-macios/detected-changes/20240506.13/9533219-1/;/stable-api-comparison/tvos-api-diff.html) [gist](https://gist.github.com/vs-mobiletools-engineering-service2/92580b6fb90a433bd323964e12b07111) (No breaking changes) * watchOS: [vsdrops](https://vsdrop.corp.microsoft.com/file/v1/xamarin-macios/detected-changes/20240506.13/9533219-1/;/stable-api-comparison/watchos-api-diff.html) [gist](https://gist.github.com/vs-mobiletools-engineering-service2/c0088f8dbc6e8a64cb757477113e7399) (No breaking changes) * macOS: [vsdrops](https://vsdrop.corp.microsoft.com/file/v1/xamarin-macios/detected-changes/20240506.13/9533219-1/;/stable-api-comparison/mac-api-diff.html) [gist](https://gist.github.com/vs-mobiletools-engineering-service2/e99d77d36f78652162bbbd945c163dfd) (No breaking changes)

.NET (No breaking changes)

* iOS: [vsdrops](https://vsdrop.corp.microsoft.com/file/v1/xamarin-macios/detected-changes/20240506.13/9533219-1/;/stable-api-comparison/diff/dotnet/Microsoft.iOS.Ref/ref/net8.0/Microsoft.iOS.html) [gist](https://gist.github.com/vs-mobiletools-engineering-service2/dbbe748d7ece01c1a99fb96a0b6f39aa) (No breaking changes) * tvOS: [vsdrops](https://vsdrop.corp.microsoft.com/file/v1/xamarin-macios/detected-changes/20240506.13/9533219-1/;/stable-api-comparison/diff/dotnet/Microsoft.tvOS.Ref/ref/net8.0/Microsoft.tvOS.html) [gist](https://gist.github.com/vs-mobiletools-engineering-service2/5ab7fe94ccda9dd419ff4a8f7e8deb9b) (No breaking changes) * MacCatalyst: [vsdrops](https://vsdrop.corp.microsoft.com/file/v1/xamarin-macios/detected-changes/20240506.13/9533219-1/;/stable-api-comparison/diff/dotnet/Microsoft.MacCatalyst.Ref/ref/net8.0/Microsoft.MacCatalyst.html) [gist](https://gist.github.com/vs-mobiletools-engineering-service2/05532c55177d8c9a3776aa5d176bb43a) (No breaking changes) * macOS: [vsdrops](https://vsdrop.corp.microsoft.com/file/v1/xamarin-macios/detected-changes/20240506.13/9533219-1/;/stable-api-comparison/diff/dotnet/Microsoft.macOS.Ref/ref/net8.0/Microsoft.macOS.html) [gist](https://gist.github.com/vs-mobiletools-engineering-service2/73139901f9d3f0c2fdf55856488e567a) (No breaking changes) * Microsoft.iOS vs Microsoft.MacCatalyst: [vsdrops](https://vsdrop.corp.microsoft.com/file/v1/xamarin-macios/detected-changes/20240506.13/9533219-1/;/stable-api-comparison/diff/dotnet/iOS-MacCatalyst-diff/Microsoft.iOS.Ref/ref/net8.0/Microsoft.iOS.MacCatalyst.html) [gist](https://gist.github.com/vs-mobiletools-engineering-service2/400950783667c6dfd1ce6b73631cff36)

Legacy Xamarin (stable) vs .NET

* iOS: [vsdrops](https://vsdrop.corp.microsoft.com/file/v1/xamarin-macios/detected-changes/20240506.13/9533219-1/;/stable-api-comparison/diff/dotnet/legacy-diff/Microsoft.iOS.Ref/ref/net8.0/Microsoft.iOS.html) [gist](https://gist.github.com/vs-mobiletools-engineering-service2/4fb3b55585d4f28a07208ee03e16db4b) * tvOS: [vsdrops](https://vsdrop.corp.microsoft.com/file/v1/xamarin-macios/detected-changes/20240506.13/9533219-1/;/stable-api-comparison/diff/dotnet/legacy-diff/Microsoft.tvOS.Ref/ref/net8.0/Microsoft.tvOS.html) [gist](https://gist.github.com/vs-mobiletools-engineering-service2/07c4f6e1b29240dbae3b8c10986e84b0) * macOS: [vsdrops](https://vsdrop.corp.microsoft.com/file/v1/xamarin-macios/detected-changes/20240506.13/9533219-1/;/stable-api-comparison/diff/dotnet/legacy-diff/Microsoft.macOS.Ref/ref/net8.0/Microsoft.macOS.html) [gist](https://gist.github.com/vs-mobiletools-engineering-service2/6d5eb6eae174f9f2b69259ffe6be5d3a)

:information_source: Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent Hash: 8a8a05e312dbdffd5b0cce29858e60e162241f56 [PR build]

vs-mobiletools-engineering-service2 commented 5 months ago

:fire: [CI Build] Test results :fire:

Test results

:x: Tests failed on VSTS: test results

3 tests crashed, 8 tests failed, 143 tests passed.

Failures

:x: fsharp tests

:fire: Failed catastrophically on VSTS: test results - fsharp (no summary found).

Html Report (VSDrops) Download

:x: mononative tests

:fire: Failed catastrophically on VSTS: test results - mononative (no summary found).

Html Report (VSDrops) Download

:x: monotouch tests (tvOS)

8 tests failed, 5 tests passed.

* monotouch-test/tvOS - simulator/Debug [dotnet]: Failed * monotouch-test/tvOS - simulator/Debug: Failed * monotouch-test/tvOS - simulator/Debug (static registrar) [dotnet]: Failed * monotouch-test/tvOS - simulator/Release (all optimizations) [dotnet]: TimedOut * monotouch-test/tvOS - simulator/Debug (managed static registrar) [dotnet]: Failed * monotouch-test/tvOS - simulator/Release (managed static registrar, all optimizations) [dotnet]: Failed * monotouch-test/tvOS - simulator/Debug (static registrar): Failed * monotouch-test/tvOS - simulator/Release (all optimizations): Failed

Html Report (VSDrops) Download

:x: xcframework tests

:fire: Failed catastrophically on VSTS: test results - xcframework (no summary found).

Html Report (VSDrops) Download

Successes

:white_check_mark: cecil: All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: framework: All 8 tests passed. Html Report (VSDrops) Download :white_check_mark: generator: All 2 tests passed. Html Report (VSDrops) Download :white_check_mark: install-source: All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: interdependent-binding-projects: All 7 tests passed. Html Report (VSDrops) Download :white_check_mark: introspection: All 8 tests passed. Html Report (VSDrops) Download :white_check_mark: linker: All 65 tests passed. Html Report (VSDrops) Download :white_check_mark: mac-binding-project: All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: mmp: All 2 tests passed. Html Report (VSDrops) Download :white_check_mark: monotouch (iOS): All 11 tests passed. Html Report (VSDrops) Download :white_check_mark: monotouch (MacCatalyst): All 7 tests passed. Html Report (VSDrops) Download :white_check_mark: monotouch (macOS): All 8 tests passed. Html Report (VSDrops) Download :white_check_mark: monotouch (watchOS): All 4 tests passed. Html Report (VSDrops) Download :white_check_mark: msbuild: All 2 tests passed. Html Report (VSDrops) Download :white_check_mark: mtouch: All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: xammac: All 3 tests passed. Html Report (VSDrops) Download :white_check_mark: xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent Hash: [PR build]

vs-mobiletools-engineering-service2 commented 5 months ago

:rocket: [CI Build] Test results :rocket:

Test results

:white_check_mark: All tests passed on VSTS: test results.

:tada: All 170 tests passed :tada:

Tests counts

:white_check_mark: cecil: All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: framework: All 8 tests passed. Html Report (VSDrops) Download :white_check_mark: fsharp: All 7 tests passed. [attempt 2] Html Report (VSDrops) Download :white_check_mark: generator: All 2 tests passed. Html Report (VSDrops) Download :white_check_mark: install-source: All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: interdependent-binding-projects: All 7 tests passed. Html Report (VSDrops) Download :white_check_mark: introspection: All 8 tests passed. Html Report (VSDrops) Download :white_check_mark: linker: All 65 tests passed. Html Report (VSDrops) Download :white_check_mark: mac-binding-project: All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: mmp: All 2 tests passed. Html Report (VSDrops) Download :white_check_mark: mononative: All 6 tests passed. [attempt 2] Html Report (VSDrops) Download :white_check_mark: monotouch (iOS): All 11 tests passed. Html Report (VSDrops) Download :white_check_mark: monotouch (MacCatalyst): All 7 tests passed. Html Report (VSDrops) Download :white_check_mark: monotouch (macOS): All 8 tests passed. Html Report (VSDrops) Download :white_check_mark: monotouch (tvOS): All 11 tests passed. [attempt 2] Html Report (VSDrops) Download :white_check_mark: monotouch (watchOS): All 4 tests passed. Html Report (VSDrops) Download :white_check_mark: msbuild: All 2 tests passed. Html Report (VSDrops) Download :white_check_mark: mtouch: All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: xammac: All 3 tests passed. Html Report (VSDrops) Download :white_check_mark: xcframework: All 8 tests passed. [attempt 2] Html Report (VSDrops) Download :white_check_mark: xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent Hash: [PR build]