Closed vs-mobiletools-engineering-service2 closed 4 months ago
:white_check_mark: All tests on macOS M1 - Mac Big Sur (11.5) passed.
Pipeline on Agent Hash: [PR build]
:white_check_mark: All tests on macOS M1 - Mac Ventura (13.0) passed.
Pipeline on Agent Hash: [PR build]
Pipeline on Agent Hash: [PR build]
:white_check_mark: All Windows Integration Tests passed.
Pipeline on Agent Hash: c5f4e064b7aca06b4891d50c7cb1acfe43a58ab2 [PR build]
Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)
Pipeline on Agent Hash: c5f4e064b7aca06b4891d50c7cb1acfe43a58ab2 [PR build]
:white_check_mark: All tests passed on VSTS: simulator tests.
:tada: All 95 tests passed :tada:
:white_check_mark: cecil: All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: dotnettests: All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: fsharp: All 4 tests passed. Html Report (VSDrops) Download :white_check_mark: framework: All 4 tests passed. Html Report (VSDrops) Download :white_check_mark: generator: All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: interdependent_binding_projects: All 4 tests passed. Html Report (VSDrops) Download :warning: install_source: No tests selected. Html Report (VSDrops) Download :white_check_mark: introspection: All 4 tests passed. Html Report (VSDrops) Download :white_check_mark: linker: All 40 tests passed. Html Report (VSDrops) Download :warning: mac_binding_project: No tests selected. Html Report (VSDrops) Download :warning: mmp: No tests selected. Html Report (VSDrops) Download :warning: mononative: No tests selected. Html Report (VSDrops) Download :white_check_mark: monotouch: All 29 tests passed. Html Report (VSDrops) Download :white_check_mark: msbuild: All 2 tests passed. Html Report (VSDrops) Download :warning: mtouch: No tests selected. Html Report (VSDrops) Download :warning: xammac: No tests selected. Html Report (VSDrops) Download :white_check_mark: xcframework: All 4 tests passed. Html Report (VSDrops) Download :white_check_mark: xtro: All 1 tests passed. Html Report (VSDrops) Download
Pipeline on Agent Hash: c5f4e064b7aca06b4891d50c7cb1acfe43a58ab2 [PR build]
The validation verifies that the function pointer for a block callback is the same the return value from the method's MethodInfo.MethodHandle.GetFunctionPointer() method.
In actual code, it's equivalent to validating that the following always prints "Equal: true":
However, this isn't documented, and some feedback indicates it's certainly not a valid assumption for CoreCLR:
https://discord.com/channels/732297728826277939/732582981163548703/1242473425759633488
And there's also a customer running into this validation, apparently withou cause: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2054534
So just remove it.
Backport of #20625