xamarin / xamarin-macios

.NET for iOS, Mac Catalyst, macOS, and tvOS provide open-source bindings of the Apple SDKs for use with .NET managed languages such as C#

Other

2.47k stars 514 forks source link

[release/8.0.1xx-xcode15.1] [dotnet] Fix detecting if the interpreter is enabled. #20732

Closed rolfbjarne closed 4 months ago

rolfbjarne commented 4 months ago

The canonical property we use for the interpreter is MtouchInterpreter - and the interpreter is enabled if MtouchInterpreter is set to any value (the MtouchInterpreter value is used to select which assemblies to interpret, the only way to completely disable the interpreter is to not set MtouchInterpreter at all).

So fix a couple of cases of wrong comparison:

Don't use UseInterpreter - which is used to compute a specific value for MtouchInterpreter - because developers don't have to set UseInterpreter to enable the interpreter, they can set MtouchInterpreter directly.
Don't compare MtouchInterpreter with true: that only checks if the assembly "true" is interpreted (which it rarely is).

Fixes https://github.com/dotnet/runtime/issues/96920.

This is a backport of #19812 and #20696.

vs-mobiletools-engineering-service2 commented 4 months ago

:computer: [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed :computer:

:white_check_mark: All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent Hash: [PR build]

vs-mobiletools-engineering-service2 commented 4 months ago

:computer: [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed :computer:

:white_check_mark: All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent Hash: [PR build]

vs-mobiletools-engineering-service2 commented 4 months ago

:books: [PR Build] Artifacts :books:

Packages generated

View packages

Pipeline on Agent Hash: [PR build]

vs-mobiletools-engineering-service2 commented 4 months ago

:computer: [CI Build] Windows Integration Tests passed :computer:

:white_check_mark: All Windows Integration Tests passed.

Pipeline on Agent Hash: f96b7b2c037416bab1a179ec136800b424988170 [PR build]

vs-mobiletools-engineering-service2 commented 4 months ago

:white_check_mark: API diff for current PR / commit

NET (empty diffs)

* ~iOS~: (empty diff detected) * ~tvOS~: (empty diff detected) * ~MacCatalyst~: (empty diff detected) * ~macOS~: (empty diff detected)

:white_check_mark: API diff vs stable

.NET (No breaking changes)

* iOS: [vsdrops](https://vsdrop.corp.microsoft.com/file/v1/xamarin-macios/detected-changes/20240617.1/9737104-1/;/stable-api-comparison/diff/dotnet/Microsoft.iOS.Ref/ref/net8.0/Microsoft.iOS.html) [gist](https://gist.github.com/vs-mobiletools-engineering-service2/37368e8fdc24b2ddde0341a2dffdb52d) (No breaking changes) * tvOS: [vsdrops](https://vsdrop.corp.microsoft.com/file/v1/xamarin-macios/detected-changes/20240617.1/9737104-1/;/stable-api-comparison/diff/dotnet/Microsoft.tvOS.Ref/ref/net8.0/Microsoft.tvOS.html) [gist](https://gist.github.com/vs-mobiletools-engineering-service2/2b781d0fda29e1eb5a21c9ba4c8f6a24) (No breaking changes) * MacCatalyst: [vsdrops](https://vsdrop.corp.microsoft.com/file/v1/xamarin-macios/detected-changes/20240617.1/9737104-1/;/stable-api-comparison/diff/dotnet/Microsoft.MacCatalyst.Ref/ref/net8.0/Microsoft.MacCatalyst.html) [gist](https://gist.github.com/vs-mobiletools-engineering-service2/055b2cddc4262a2e865d23bd0fb10cbd) (No breaking changes) * macOS: [vsdrops](https://vsdrop.corp.microsoft.com/file/v1/xamarin-macios/detected-changes/20240617.1/9737104-1/;/stable-api-comparison/diff/dotnet/Microsoft.macOS.Ref/ref/net8.0/Microsoft.macOS.html) [gist](https://gist.github.com/vs-mobiletools-engineering-service2/ed233dccf92a026535c3436dbe268833) (No breaking changes) * Microsoft.iOS vs Microsoft.MacCatalyst: [vsdrops](https://vsdrop.corp.microsoft.com/file/v1/xamarin-macios/detected-changes/20240617.1/9737104-1/;/stable-api-comparison/diff/dotnet/iOS-MacCatalyst-diff/Microsoft.iOS.Ref/ref/net8.0/Microsoft.iOS.MacCatalyst.html) [gist](https://gist.github.com/vs-mobiletools-engineering-service2/5c64a86f497894b5bad6befd8b980b93)

:information_source: Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent Hash: f96b7b2c037416bab1a179ec136800b424988170 [PR build]

vs-mobiletools-engineering-service2 commented 4 months ago

:fire: [CI Build] Test results :fire:

Test results

:x: Tests failed on VSTS: simulator tests

2 tests crashed, 1 tests failed, 90 tests passed.

Failures

:x: dotnettests tests

1 tests failed, 0 tests passed.

* DotNet tests: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

:x: fsharp tests

:fire: Failed catastrophically on VSTS: simulator tests - fsharp (no summary found).

Html Report (VSDrops) Download

:x: mononative tests

:fire: Failed catastrophically on VSTS: simulator tests - mononative (no summary found).

Html Report (VSDrops) Download

Successes

:white_check_mark: cecil: All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: framework: All 4 tests passed. Html Report (VSDrops) Download :white_check_mark: generator: All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: interdependent_binding_projects: All 4 tests passed. Html Report (VSDrops) Download :warning: install_source: No tests selected. Html Report (VSDrops) Download :white_check_mark: introspection: All 4 tests passed. Html Report (VSDrops) Download :white_check_mark: linker: All 40 tests passed. Html Report (VSDrops) Download :warning: mac_binding_project: No tests selected. Html Report (VSDrops) Download :warning: mmp: No tests selected. Html Report (VSDrops) Download :white_check_mark: monotouch: All 29 tests passed. Html Report (VSDrops) Download :white_check_mark: msbuild: All 2 tests passed. Html Report (VSDrops) Download :warning: mtouch: No tests selected. Html Report (VSDrops) Download :warning: xammac: No tests selected. Html Report (VSDrops) Download :white_check_mark: xcframework: All 4 tests passed. Html Report (VSDrops) Download :white_check_mark: xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent Hash: f96b7b2c037416bab1a179ec136800b424988170 [PR build]

vs-mobiletools-engineering-service2 commented 4 months ago

:fire: [CI Build] Test results :fire:

Test results

:x: Tests failed on VSTS: simulator tests

1 tests crashed, 0 tests failed, 94 tests passed.

Failures

:x: dotnettests tests

:fire: Failed catastrophically on VSTS: simulator tests - dotnettests (no summary found).

Html Report (VSDrops) Download

Successes

:white_check_mark: cecil: All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: fsharp: All 4 tests passed. [attempt 2] Html Report (VSDrops) Download :white_check_mark: framework: All 4 tests passed. Html Report (VSDrops) Download :white_check_mark: generator: All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: interdependent_binding_projects: All 4 tests passed. Html Report (VSDrops) Download :warning: install_source: No tests selected. Html Report (VSDrops) Download :white_check_mark: introspection: All 4 tests passed. Html Report (VSDrops) Download :white_check_mark: linker: All 40 tests passed. Html Report (VSDrops) Download :warning: mac_binding_project: No tests selected. Html Report (VSDrops) Download :warning: mmp: No tests selected. Html Report (VSDrops) Download :warning: mononative: No tests selected. [attempt 2] Html Report (VSDrops) Download :white_check_mark: monotouch: All 29 tests passed. Html Report (VSDrops) Download :white_check_mark: msbuild: All 2 tests passed. Html Report (VSDrops) Download :warning: mtouch: No tests selected. Html Report (VSDrops) Download :warning: xammac: No tests selected. Html Report (VSDrops) Download :white_check_mark: xcframework: All 4 tests passed. Html Report (VSDrops) Download :white_check_mark: xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent Hash: f96b7b2c037416bab1a179ec136800b424988170 [PR build]

vs-mobiletools-engineering-service2 commented 4 months ago

:rocket: [CI Build] Test results :rocket:

Test results

:white_check_mark: All tests passed on VSTS: simulator tests.

:tada: All 95 tests passed :tada:

Tests counts

:white_check_mark: cecil: All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: dotnettests: All 1 tests passed. [attempt 3] Html Report (VSDrops) Download :white_check_mark: fsharp: All 4 tests passed. [attempt 2] Html Report (VSDrops) Download :white_check_mark: framework: All 4 tests passed. Html Report (VSDrops) Download :white_check_mark: generator: All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: interdependent_binding_projects: All 4 tests passed. Html Report (VSDrops) Download :warning: install_source: No tests selected. Html Report (VSDrops) Download :white_check_mark: introspection: All 4 tests passed. Html Report (VSDrops) Download :white_check_mark: linker: All 40 tests passed. Html Report (VSDrops) Download :warning: mac_binding_project: No tests selected. Html Report (VSDrops) Download :warning: mmp: No tests selected. Html Report (VSDrops) Download :warning: mononative: No tests selected. [attempt 2] Html Report (VSDrops) Download :white_check_mark: monotouch: All 29 tests passed. Html Report (VSDrops) Download :white_check_mark: msbuild: All 2 tests passed. Html Report (VSDrops) Download :warning: mtouch: No tests selected. Html Report (VSDrops) Download :warning: xammac: No tests selected. Html Report (VSDrops) Download :white_check_mark: xcframework: All 4 tests passed. Html Report (VSDrops) Download :white_check_mark: xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent Hash: f96b7b2c037416bab1a179ec136800b424988170 [PR build]