search

xamarin / xamarin-macios

.NET for iOS, Mac Catalyst, macOS, and tvOS provide open-source bindings of the Apple SDKs for use with .NET managed languages such as C#
Other
2.44k stars 509 forks source link

[Globalization] Remove Unused ICU Files #20827

Closed mkhamoyan closed 2 months ago

mkhamoyan commented 2 months ago

We don't use anymore icu .dat files.

Contributes to https://github.com/dotnet/runtime/issues/99521

ivanpovazan commented 2 months ago

I think this only applies to .NET9, right? In that case, we should instead have a condition on the target framework version.

On the side note: I don't think CI triggers for PRs from forks anymore. If I am not mistaken you will need to create a branch like: dev/<username>/<branchname>, push to the origin, and then create a PR from that branch instead.

mkhamoyan commented 2 months ago

On the side note: I don't think CI triggers for PRs from forks anymore. If I am not mistaken you will need to create a branch like: dev/<username>/<branchname>, push to the origin, and then create a PR from that branch instead.

Thanks, I'll close this then.