search

xamarin / xamarin-macios

.NET for iOS, Mac Catalyst, macOS, and tvOS provide open-source bindings of the Apple SDKs for use with .NET managed languages such as C#
Other
2.47k stars 514 forks source link

[nuget-msi-convert] Do not use new VS component IDs #21476

Closed pjcollins closed 2 weeks ago

pjcollins commented 2 weeks ago

Context: https://github.com/xamarin/xamarin-macios/commit/9013ae4f83a9236ac91a8fe857a2403371993534

We've decided hold off on this change until .NET 10.

pjcollins commented 2 weeks ago

We'll need this in all .NET 9 branches where this prop was added and set to true.

dalexsoto commented 2 weeks ago

@rolfbjarne / @pjcollins this is likely to be reverted if we are not careful with the main merges to our net10.0 branch

dalexsoto commented 2 weeks ago

We'll need this in all .NET 9 branches where this prop was added and set to true.

so we wil probably also need this in the net9.0 branch

vs-mobiletools-engineering-service2 commented 2 weeks ago

:computer: [CI Build] Windows Integration Tests passed :computer:

:white_check_mark: All Windows Integration Tests passed.

Pipeline on Agent Hash: fb4ed76ad9102c6e1c121d1e48d153c16a06fc51 [PR build]

vs-mobiletools-engineering-service2 commented 2 weeks ago

:white_check_mark: API diff for current PR / commit

.NET (No breaking changes) * iOS: [vsdrops](https://vsdrop.corp.microsoft.com/file/v1/xamarin-macios/detected-changes/20241017.38/10408725-1/;/previous-api-comparison/diff/Microsoft.iOS.html) [gist](https://gist.github.com/vs-mobiletools-engineering-service2/a546bc17c25231dd13026ca849e39c23) (No breaking changes) * tvOS: [vsdrops](https://vsdrop.corp.microsoft.com/file/v1/xamarin-macios/detected-changes/20241017.38/10408725-1/;/previous-api-comparison/diff/Microsoft.tvOS.html) [gist](https://gist.github.com/vs-mobiletools-engineering-service2/b43f163ba530ab5df40fc9dee3848f81) (No breaking changes) * MacCatalyst: [vsdrops](https://vsdrop.corp.microsoft.com/file/v1/xamarin-macios/detected-changes/20241017.38/10408725-1/;/previous-api-comparison/diff/Microsoft.MacCatalyst.html) [gist](https://gist.github.com/vs-mobiletools-engineering-service2/4d11d3a288664df084aa7c47d5603d6a) (No breaking changes) * macOS: [vsdrops](https://vsdrop.corp.microsoft.com/file/v1/xamarin-macios/detected-changes/20241017.38/10408725-1/;/previous-api-comparison/diff/Microsoft.macOS.html) [gist](https://gist.github.com/vs-mobiletools-engineering-service2/cabe29a291169eef4500fb700e82e291) (No breaking changes)

:white_check_mark: API diff vs stable

.NET (No breaking changes) * iOS: [vsdrops](https://vsdrop.corp.microsoft.com/file/v1/xamarin-macios/detected-changes/20241017.38/10408725-1/;/stable-api-comparison/diff/Microsoft.iOS.html) [gist](https://gist.github.com/vs-mobiletools-engineering-service2/7c30a9869503ef11543eb31153e7c29b) (No breaking changes) * tvOS: [vsdrops](https://vsdrop.corp.microsoft.com/file/v1/xamarin-macios/detected-changes/20241017.38/10408725-1/;/stable-api-comparison/diff/Microsoft.tvOS.html) [gist](https://gist.github.com/vs-mobiletools-engineering-service2/c125c5bb6c12a580131dc757996b0e70) (No breaking changes) * MacCatalyst: [vsdrops](https://vsdrop.corp.microsoft.com/file/v1/xamarin-macios/detected-changes/20241017.38/10408725-1/;/stable-api-comparison/diff/Microsoft.MacCatalyst.html) [gist](https://gist.github.com/vs-mobiletools-engineering-service2/efa703b04dbe10833bc9cca863651c16) (No breaking changes) * macOS: [vsdrops](https://vsdrop.corp.microsoft.com/file/v1/xamarin-macios/detected-changes/20241017.38/10408725-1/;/stable-api-comparison/diff/Microsoft.macOS.html) [gist](https://gist.github.com/vs-mobiletools-engineering-service2/44019ee7b60ea660fa32c818f8c08f15) (No breaking changes)

:information_source: Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent Hash: fb4ed76ad9102c6e1c121d1e48d153c16a06fc51 [PR build]

vs-mobiletools-engineering-service2 commented 2 weeks ago

:computer: [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed :computer:

:white_check_mark: All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent Hash: fb4ed76ad9102c6e1c121d1e48d153c16a06fc51 [PR build]

vs-mobiletools-engineering-service2 commented 2 weeks ago

:computer: [CI Build] Tests on macOS M1 - Mac Monterey (12) passed :computer:

:white_check_mark: All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent Hash: fb4ed76ad9102c6e1c121d1e48d153c16a06fc51 [PR build]

vs-mobiletools-engineering-service2 commented 2 weeks ago

:computer: [CI Build] Tests on macOS M1 - Mac Ventura (13) passed :computer:

:white_check_mark: All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent Hash: fb4ed76ad9102c6e1c121d1e48d153c16a06fc51 [PR build]

vs-mobiletools-engineering-service2 commented 2 weeks ago

:fire: [CI Build] Test results :fire:

Test results

:x: Tests failed on VSTS: test results

3 tests crashed, 0 tests failed, 98 tests passed.

Failures

:x: cecil tests

:fire: Failed catastrophically on VSTS: test results - cecil (no summary found).

Html Report (VSDrops) Download

:x: dotnettests tests (iOS)

:fire: Failed catastrophically on VSTS: test results - dotnettests_ios (no summary found).

Html Report (VSDrops) Download

:x: dotnettests tests (tvOS)

:fire: Failed catastrophically on VSTS: test results - dotnettests_tvos (no summary found).

Html Report (VSDrops) Download

Successes

:white_check_mark: dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: framework: All 2 tests passed. Html Report (VSDrops) Download :white_check_mark: fsharp: All 4 tests passed. Html Report (VSDrops) Download :white_check_mark: generator: All 3 tests passed. Html Report (VSDrops) Download :white_check_mark: interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download :white_check_mark: introspection: All 4 tests passed. Html Report (VSDrops) Download :white_check_mark: linker: All 40 tests passed. Html Report (VSDrops) Download :white_check_mark: monotouch (iOS): All 7 tests passed. Html Report (VSDrops) Download :white_check_mark: monotouch (MacCatalyst): All 8 tests passed. Html Report (VSDrops) Download :white_check_mark: monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download :white_check_mark: monotouch (tvOS): All 7 tests passed. Html Report (VSDrops) Download :white_check_mark: msbuild: All 2 tests passed. Html Report (VSDrops) Download :white_check_mark: xcframework: All 4 tests passed. Html Report (VSDrops) Download :white_check_mark: xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent Hash: fb4ed76ad9102c6e1c121d1e48d153c16a06fc51 [PR build]

rolfbjarne commented 2 weeks ago

/sudo backport net9.0

rolfbjarne commented 2 weeks ago

@rolfbjarne / @pjcollins this is likely to be reverted if we are not careful with the main merges to our net10.0 branch

We'll have to re-apply the initial change in net10.0 once we've merged main into net10.0 the next time.

vs-mobiletools-engineering-service2 commented 2 weeks ago

Backport Job to branch net9.0 Created! The magic is happening here

vs-mobiletools-engineering-service2 commented 2 weeks ago

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=10414173 for more details.

vs-mobiletools-engineering-service2 commented 2 weeks ago

:rocket: [CI Build] Test results :rocket:

Test results

:white_check_mark: All tests passed on VSTS: test results.

:tada: All 101 tests passed :tada:

Tests counts

:white_check_mark: cecil: All 1 tests passed. [attempt 2] Html Report (VSDrops) Download :white_check_mark: dotnettests (iOS): All 1 tests passed. [attempt 2] Html Report (VSDrops) Download :white_check_mark: dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: dotnettests (tvOS): All 1 tests passed. [attempt 2] Html Report (VSDrops) Download :white_check_mark: framework: All 2 tests passed. Html Report (VSDrops) Download :white_check_mark: fsharp: All 4 tests passed. Html Report (VSDrops) Download :white_check_mark: generator: All 3 tests passed. Html Report (VSDrops) Download :white_check_mark: interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download :white_check_mark: introspection: All 4 tests passed. Html Report (VSDrops) Download :white_check_mark: linker: All 40 tests passed. Html Report (VSDrops) Download :white_check_mark: monotouch (iOS): All 7 tests passed. Html Report (VSDrops) Download :white_check_mark: monotouch (MacCatalyst): All 8 tests passed. Html Report (VSDrops) Download :white_check_mark: monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download :white_check_mark: monotouch (tvOS): All 7 tests passed. Html Report (VSDrops) Download :white_check_mark: msbuild: All 2 tests passed. Html Report (VSDrops) Download :white_check_mark: xcframework: All 4 tests passed. Html Report (VSDrops) Download :white_check_mark: xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent Hash: fb4ed76ad9102c6e1c121d1e48d153c16a06fc51 [PR build]

rolfbjarne commented 2 weeks ago

@rolfbjarne / @pjcollins this is likely to be reverted if we are not careful with the main merges to our net10.0 branch

We'll have to re-apply the initial change in net10.0 once we've merged main into net10.0 the next time.

I've merged main into net10.0 (#21480), and re-applied the fix there (https://github.com/xamarin/xamarin-macios/pull/21480/commits/04f4de35ebd598282b098bb60c37775de0f7cc3c)