search

xamarin / xamarin-macios

.NET for iOS, Mac Catalyst, macOS, and tvOS provide open-source bindings of the Apple SDKs for use with .NET managed languages such as C#
Other
2.49k stars 515 forks source link

[UIKit] Inline the UITraitChangeObservable protocol into the classes that implement it. Fixes #20265. #21676

Open rolfbjarne opened 4 days ago

rolfbjarne commented 4 days ago

This also required fixing:

Also:

Ref: https://github.com/xamarin/xamarin-macios/issues/19410#issuecomment-1898185477

Fixes https://github.com/xamarin/xamarin-macios/issues/20265.

github-actions[bot] commented 4 days ago

:warning: Your code has been reformatted. :warning:

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

vs-mobiletools-engineering-service2 commented 4 days ago

:x: [CI Build] Windows Integration Tests failed :x:

:x: Failed :x:

Pipeline on Agent Hash: 03c134618d598eef1160a63d5b4aa86cff360113 [PR build]

vs-mobiletools-engineering-service2 commented 4 days ago

:white_check_mark: API diff for current PR / commit

.NET (No breaking changes) * iOS: [vsdrops](https://vsdrop.corp.microsoft.com/file/v1/xamarin-macios/detected-changes/20241121.9/10595434-1/;/previous-api-comparison/diff/Microsoft.iOS.html) [gist](https://gist.github.com/vs-mobiletools-engineering-service2/c01f96bcbf291bed84f71f24b3040257) (No breaking changes) * tvOS: [vsdrops](https://vsdrop.corp.microsoft.com/file/v1/xamarin-macios/detected-changes/20241121.9/10595434-1/;/previous-api-comparison/diff/Microsoft.tvOS.html) [gist](https://gist.github.com/vs-mobiletools-engineering-service2/5fd33a978630157f7a02b40cd089db3a) (No breaking changes) * MacCatalyst: [vsdrops](https://vsdrop.corp.microsoft.com/file/v1/xamarin-macios/detected-changes/20241121.9/10595434-1/;/previous-api-comparison/diff/Microsoft.MacCatalyst.html) [gist](https://gist.github.com/vs-mobiletools-engineering-service2/8590cf5beb8c1633dcdd2b1dec2cee2d) (No breaking changes) * macOS: [vsdrops](https://vsdrop.corp.microsoft.com/file/v1/xamarin-macios/detected-changes/20241121.9/10595434-1/;/previous-api-comparison/diff/Microsoft.macOS.html) [gist](https://gist.github.com/vs-mobiletools-engineering-service2/0a37d604edd844b7c7c3716510404637) (No breaking changes)

:white_check_mark: API diff vs stable

.NET (No breaking changes) * iOS: [vsdrops](https://vsdrop.corp.microsoft.com/file/v1/xamarin-macios/detected-changes/20241121.9/10595434-1/;/stable-api-comparison/diff/Microsoft.iOS.html) [gist](https://gist.github.com/vs-mobiletools-engineering-service2/9f4cac2822dc7e717d66b40da0e114fa) (No breaking changes) * tvOS: [vsdrops](https://vsdrop.corp.microsoft.com/file/v1/xamarin-macios/detected-changes/20241121.9/10595434-1/;/stable-api-comparison/diff/Microsoft.tvOS.html) [gist](https://gist.github.com/vs-mobiletools-engineering-service2/2c2b22a2e5631e96feb7b44acf85d0b3) (No breaking changes) * MacCatalyst: [vsdrops](https://vsdrop.corp.microsoft.com/file/v1/xamarin-macios/detected-changes/20241121.9/10595434-1/;/stable-api-comparison/diff/Microsoft.MacCatalyst.html) [gist](https://gist.github.com/vs-mobiletools-engineering-service2/a5d2f70b1a4b301b800d9653a5af674d) (No breaking changes) * macOS: [vsdrops](https://vsdrop.corp.microsoft.com/file/v1/xamarin-macios/detected-changes/20241121.9/10595434-1/;/stable-api-comparison/diff/Microsoft.macOS.html) [gist](https://gist.github.com/vs-mobiletools-engineering-service2/29d33a3d1e6e183d0d801d0b8836ac43) (No breaking changes)

:information_source: Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent Hash: 03c134618d598eef1160a63d5b4aa86cff360113 [PR build]

vs-mobiletools-engineering-service2 commented 4 days ago

:computer: [CI Build] Tests on macOS M1 - Mac Monterey (12) passed :computer:

:white_check_mark: All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent Hash: 03c134618d598eef1160a63d5b4aa86cff360113 [PR build]

vs-mobiletools-engineering-service2 commented 4 days ago

:computer: [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed :computer:

:white_check_mark: All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent Hash: 03c134618d598eef1160a63d5b4aa86cff360113 [PR build]

vs-mobiletools-engineering-service2 commented 4 days ago

:computer: [CI Build] Tests on macOS M1 - Mac Ventura (13) passed :computer:

:white_check_mark: All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent Hash: 03c134618d598eef1160a63d5b4aa86cff360113 [PR build]

vs-mobiletools-engineering-service2 commented 4 days ago

:fire: [CI Build] Test results :fire:

Test results

:x: Tests failed on VSTS: test results

0 tests crashed, 1 tests failed, 110 tests passed.

Failures

:x: monotouch tests (macOS)

1 tests failed, 12 tests passed.
* monotouch-test/Mac Catalyst [dotnet]/Debug (ARM64) [dotnet]: BuildFailure

Html Report (VSDrops) Download

Successes

:white_check_mark: cecil: All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: framework: All 2 tests passed. Html Report (VSDrops) Download :white_check_mark: fsharp: All 4 tests passed. Html Report (VSDrops) Download :white_check_mark: generator: All 3 tests passed. Html Report (VSDrops) Download :white_check_mark: interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download :white_check_mark: introspection: All 6 tests passed. Html Report (VSDrops) Download :white_check_mark: linker: All 40 tests passed. Html Report (VSDrops) Download :white_check_mark: monotouch (iOS): All 7 tests passed. Html Report (VSDrops) Download :white_check_mark: monotouch (MacCatalyst): All 10 tests passed. Html Report (VSDrops) Download :white_check_mark: monotouch (tvOS): All 9 tests passed. Html Report (VSDrops) Download :white_check_mark: msbuild: All 2 tests passed. Html Report (VSDrops) Download :white_check_mark: xcframework: All 4 tests passed. Html Report (VSDrops) Download :white_check_mark: xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent Hash: 03c134618d598eef1160a63d5b4aa86cff360113 [PR build]

vs-mobiletools-engineering-service2 commented 4 days ago

:x: [CI Build] Windows Integration Tests failed :x:

:x: Failed :x:

Pipeline on Agent Hash: 03c134618d598eef1160a63d5b4aa86cff360113 [PR build]

vs-mobiletools-engineering-service2 commented 4 days ago

:rocket: [CI Build] Test results :rocket:

Test results

:white_check_mark: All tests passed on VSTS: test results.

:tada: All 107 tests passed :tada:

Tests counts

:white_check_mark: cecil: All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: framework: All 2 tests passed. Html Report (VSDrops) Download :white_check_mark: fsharp: All 4 tests passed. Html Report (VSDrops) Download :white_check_mark: generator: All 3 tests passed. Html Report (VSDrops) Download :white_check_mark: interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download :white_check_mark: introspection: All 6 tests passed. Html Report (VSDrops) Download :white_check_mark: linker: All 40 tests passed. Html Report (VSDrops) Download :white_check_mark: monotouch (iOS): All 7 tests passed. Html Report (VSDrops) Download :white_check_mark: monotouch (MacCatalyst): All 10 tests passed. Html Report (VSDrops) Download :white_check_mark: monotouch (macOS): All 9 tests passed. [attempt 2] Html Report (VSDrops) Download :white_check_mark: monotouch (tvOS): All 9 tests passed. Html Report (VSDrops) Download :white_check_mark: msbuild: All 2 tests passed. Html Report (VSDrops) Download :white_check_mark: xcframework: All 4 tests passed. Html Report (VSDrops) Download :white_check_mark: xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent Hash: 03c134618d598eef1160a63d5b4aa86cff360113 [PR build]

vs-mobiletools-engineering-service2 commented 4 days ago

:computer: [CI Build] Windows Integration Tests passed :computer:

:white_check_mark: All Windows Integration Tests passed.

Pipeline on Agent Hash: 03c134618d598eef1160a63d5b4aa86cff360113 [PR build]