xamarin / xamarin-macios

.NET for iOS, Mac Catalyst, macOS, and tvOS provide open-source bindings of the Apple SDKs for use with .NET managed languages such as C#
Other
2.44k stars 508 forks source link

[XI] doesn't support QuickLook extensions #5335

Open mykyta-bondarenko opened 5 years ago

mykyta-bondarenko commented 5 years ago

I am porting swift sample into the Xamarin and found that XI doesn't support QuickLook extensions.

Steps to Reproduce

  1. Download a sample
  2. Run it
  3. Create an internal document and save it ('Done' button)

Expected Behavior

QLThumbnailProvider implementation is invoked and thumbnail is created

screen shot 2018-12-31 at 11 19 06

Actual Behavior

There is default icon and no additional call

screen shot 2018-12-31 at 11 15 56

Environment

  1. VSfM https://gist.github.com/mykyta-bondarenko-gl/56bb56c36608563c29d56040a0e55252

Build Logs

  1. Build Output https://gist.github.com/mykyta-bondarenko-gl/2ed4831f94368b3a00054b0c0c87ff52

Example Project

Particles

spouliot commented 5 years ago

I only recall QuickLook from macOS... from the logs there's at least some places when it's not implemented.

https://gist.github.com/mykyta-bondarenko-gl/2ed4831f94368b3a00054b0c0c87ff52#file-build-output-L10686

/Library/Frameworks/Mono.framework/External/xbuild/Xamarin/iOS/Xamarin.iOS.Common.targets(1644,3): warning : The App Extension 'Particles.Preview' has an unrecognized NSExtensionPointIdentifier value ('com.apple.quicklook.preview').

/Library/Frameworks/Mono.framework/External/xbuild/Xamarin/iOS/Xamarin.iOS.Common.targets(1644,3): warning : The App Extension 'Particles.Thumbnails' has an unrecognized NSExtensionPointIdentifier value ('com.apple.quicklook.thumbnail').
heshuimu commented 5 years ago

I was working on adding a QuickLook extension to my Xamarin.iOS project and I am very surprised that QuickLook is not implemented yet. Since this is not labeled help wanted or bug, per the Contribution Guideline I'll have to ask the issue owner (though no one is assigned): @spouliot Is it OK if I could take a stab at this?

spouliot commented 5 years ago

@heshuimu sorry I missed your original comment (lost in too many emails) :( You're most welcome to have a stab at this. Feel free to reach out to us on Gitter if you have any question :)

corliss commented 4 years ago

Hi, I just ran into this issue. Why is it not a high priority issue? It means that document based apps will not be able to return a thumbnail.

Is there a simple way to implement Quicklook extensions using Xamarin, or is this something that the Xamarin team needs to wrap and expose?

anassisi2 commented 4 years ago

I'm looking for a Quicklook Extension as well for my app files. (Xamarin Forms + iOS) @Sebastien, do you have a sample project to share?

mobilinked commented 4 years ago

Same issue here. Would you please help to share the current status or your plan?