search

xamarin / xamarin-macios

.NET for iOS, Mac Catalyst, macOS, and tvOS provide open-source bindings of the Apple SDKs for use with .NET managed languages such as C#
Other
2.48k stars 514 forks source link

Dollar sign in BUILD_REVISION #8185

Closed premun closed 4 years ago

premun commented 4 years ago

Looks like we are adding an extra character when calling mlaunch.

https://github.com/xamarin/xamarin-macios/blob/a0aa48465b718c67c8508d0883875d351ab9ff63/tests/xharness/AppRunner.cs#L397

This ends up adding following argument:

-setenv=BUILD_REVISION=$jenkins

Not sure the $ is intentional there but other parts of the code are adding just the string jenkins: https://github.com/xamarin/xamarin-macios/blob/a0aa48465b718c67c8508d0883875d351ab9ff63/tests/xharness/Jenkins/Jenkins.cs#L1159

premun commented 4 years ago

@rolfbjarne can you take a look at this and verify whether this is intentional?

rolfbjarne commented 4 years ago

This is not intentional, it should do BUILD_REVISION=jenkins.

premun commented 4 years ago

I will make a fix for this. But would merge https://github.com/xamarin/xamarin-macios/pull/8167 first to be honest. To unblock the pipeline