xamberl / DFT-raMO

DFT-raMO and tools to support DFT-raMO, a Wannier-type analysis.
GNU General Public License v3.0
2 stars 1 forks source link

Support for non-diagonal k-point meshes #42

Open brainandforce opened 1 year ago

brainandforce commented 1 year ago

Currently, a lot of the code assumes that the k-point mesh is represented by a diagonal matrix, but in reality, the k-point mesh is actually a matrix which may have off-diagonal components. It can be advantageous to use those in some contexts (for example, unit cells that are not orthorhombic), so I'm opening this issue to see if we can treat k-point meshes more rigorously.

xamberl commented 1 year ago

DFT-raMO requires a large supercell to fold the k-points of the Brillouin zone onto the gamma point. The k-point mesh for the preparatory calculations must correspond to this large supercell.

It is mathematically possible to generate a large orthorhombic supercell from a non-orthogonal unit cell. However, I think we also will need to consider how a user will figure out what k-point mesh to use. I don't think this is a priority at the moment.

brainandforce commented 1 year ago

I don't think this is a priority at the moment.

Agreed, I figure it's good to open this issue, but I've labeled it as an enhancement as not critical at the moment.