search

xan1242 / NFS-XtendedInput

NFS (Black Box, MW & newer) - XInput Plugin
MIT License
112 stars 7 forks source link

PS3 icon hashes and placeholder TPK icons #21

Closed TorutheRedFox closed 2 years ago

TorutheRedFox commented 2 years ago

Xbox 360 icons aren't yet implemented and instead just use Xbox One hashes in the switches (I might do another PR tomorrow to fix that with placeholder icons in the TPK, don't have time to do that today though)

xan1242 commented 2 years ago

Sorry but I cannot accept this.

88efd51: as I've already said, I will not support old XInput on new SDKs. Sliding this one in with the texture pull request is not gonna be accepted.

Secondly, no need to include PNGs in the repo unless all textures do the same. Besides, I've already limited the number of mipmaps generated to 2 manually, which I doubt the texture conversion tools usually are able to do. (And I won't include third party tools, in binary especially, unless absolutely necessary. This is mainly to avoid licensing issues.)

Thirdly, as I've already noted in the issue you opened, I'm working with Aero on this one already. I'll consider using your textures once he's done with his part and when we discuss it (which won't be done through this PR but through the issue).

I'm closing this PR, the discussion will continue in the issue you opened.