search

xan1242 / XNFSMusicPlayer

Xan's NFS Music Player - Custom music player replacement and a BASS library interface for NFS.
MIT License
26 stars 1 forks source link

[Installer] - Better fail checks #7

Open xan1242 opened 2 years ago

xan1242 commented 2 years ago

Installer does NOT work under Wine/Proton because the work directory is wrong.

Secondly, the installer says it succeeded even though it clearly failed because of this.

xan1242 commented 2 years ago

So this actually seems to be an issue with Wine's command interpreter.

For a 'for' loop, it doesn't accept paths in quotation marks as an argument and it fails instantly. On Windows this works just fine.

for %%f in ("InteractiveMusic/*.asf") won't do anything

for %%f in (InteractiveMusic/*.asf) will work

This is very janky anyways and it needs a better way to call the process (instead of issuing the system command) but I guess this will have to do for now.

(I guess this will have to be noted in a Wine bug report if it hadn't been done already)

xan1242 commented 2 years ago

For MW it was fixed in https://github.com/xan1242/XNFSMusicPlayer/commit/d22a65e3cc3ff1f101d8d53850c6df0f0614e894

Carbon is next...

xan1242 commented 2 years ago

Carbon issues fixed in https://github.com/xan1242/XNFSMusicPlayer/commit/b7d85359ce08e42bc0ab51f5071eca3c62424d49

Next would be to implement better error checks.

xan1242 commented 1 year ago

Halting this issue until this is resolved: https://github.com/xan1242/XNFSMusicPlayer/issues/15

Considering the removal of interactive music means removal of the installer.