xanderdeseyn / react-native-responsive-linechart

A customizable and responsive line or area chart for react-native
https://react-native-responsive-linechart.surge.sh
MIT License
202 stars 46 forks source link

Border is not used in <Line /> #119

Open mikeislearning opened 3 years ago

mikeislearning commented 3 years ago

Here's what my line code looks like, and works fine:

  <Line
    theme={{
      stroke: { color: "blue", width: 2 },
      scatter: {
        default: {
          width: 12,
          height: 12,
          rx: 12,
          color: "blue",
          border: {
            color: "red",
            width: 10,
            dashArray: [5],
          },
        },
      },
    }}
  />
Screen Shot 2021-08-24 at 10 59 44 AM

But it doesn't seem to recognize the values passed into "border". I read through the source code, and it doesn't look like the values from border are being applied. Anyone have a way to resolve this?

pettinz commented 2 years ago

Fixed in my pull request #147

Engazan commented 2 years ago

still not merged :/