xanderdeseyn / react-native-responsive-linechart

A customizable and responsive line or area chart for react-native
https://react-native-responsive-linechart.surge.sh
MIT License
202 stars 46 forks source link

Remove selected value when touch is terminated, also added callback #32

Closed natioskar closed 3 years ago

natioskar commented 3 years ago

Hey! first of all thanks for this repo very easy to work and very well documented!

This is merely a suggestion, Currently when touch is starting the last selected data point gets recorded and never disappears, This removes it when the touch is terminated.

Also in my case I used the selected tooltip data to change the displayed data in other component, so the onTooltipSelectEnd callback is being used to restore the original state (of the other component)

xanderdeseyn commented 3 years ago

Thanks for the PR! I will review & merge today or tomorrow somewhere