search

xanderdeseyn / react-native-responsive-linechart

A customizable and responsive line or area chart for react-native
https://react-native-responsive-linechart.surge.sh
MIT License
203 stars 47 forks source link

The vertical axis label is hidden #53

Closed chende008 closed 3 years ago

chende008 commented 3 years ago

https://user-images.githubusercontent.com/4397067/104445135-b9e22c80-55d3-11eb-9fcb-4ce1d498f17d.mov

During the sliding process, I don’t know why the first and last labels of the vertical axis are hidden (no rule found), I don’t know what I did wrong

xanderdeseyn commented 3 years ago

Wow, that is incredibly weird! I'll see if I can reproduce this

chende008 commented 3 years ago

Hello, I wrote a demo program, which can reproduce the above problems stably. Please take a look at it. The following is the demo link address responsive_linechart_bug

xanderdeseyn commented 3 years ago

Thanks for the demo. I'll check it out asap.

chende008 commented 3 years ago

Hello, may I ask the question I have feedback, can you reproduce it smoothly through Demo? Is there any new progress in fixing the problem?

xanderdeseyn commented 3 years ago

hi @chende008, I have not been able to look at it yet, but I should have some time today!

xanderdeseyn commented 3 years ago

Hmm your sample app is broken on the latest release (5.5.0).

Warning: Maximum update depth exceeded. This can happen when a component calls setState inside useEffect, but useEffect either doesn't have a dependency array, or one of the dependencies changes on every render. in ForwardRef(Line) (at App.js:54)

I'll have to check this out first
xanderdeseyn commented 3 years ago

Issue should be fixed in v5.5.1, as well as the error I encountered above ^. Turned out to be a floating point comparison going wrong: 0.4404 < 0.44039999999999

Thanks for providing a reproducible demo, would not have found it otherwise.

chende008 commented 3 years ago

Thank you very much, confirm that the problem has been resolved.