Crafting Tables Pull from Nearby Chests

[xanderdunn]

Pulling items from the user's inventory is a pain in the ass. Instead, pull everything from a nearby designated chest.

• [x] Look at what script is attached to the alchemy table, smithing tables, and enchanting table and edit them.

[xanderdunn]

It looks like the location where workbenches get their items is hardcoded to the player.

Idea: Move all items in a container to the player's inventory and then back to the container when done.

1. Set a custom script on the container that adds every added Form to a FormList:

ScriptName aaCustomContainerScript extends ObjectReference

FormList Property aaItemList auto

Event OnItemAdded(Form akBaseItem, int aiItemCount, ObjectReference akItemReference, ObjectReference akSourceContainer)

    While aiItemCount > 0
        aaItemList.AddForm(akBaseItem) ; tracking list of items in container
        aiItemCount -= 1
    EndWhile

EndEvent

1. Move from container to RemoveAllItems(akTransferTo = Player, abKeepOwnership = true).
   • Will this add the items to the player silently?
   • Will I need to increase the player's max carry weight for this to work?
   • You could use an AddInventoryEventFilter to ignore any items the player might put in that aren't ingredients
2. Two possibilities for getting the items back into the container:
   • Iterate through all the forms in the FormList to move it to the container if it still exists. (This will work only if the used items have a checkable state change from the unused ones)
   • Every time the player uses an item, if it is in the FormList, remove it. Then simply move all items in the FormList to the container on workbench completion.

[xanderdunn]

The above isn't going to work because Papyrus is too slow, it doesn't tell me how much of each item is being removed from a container or allow me to get a list of what is in a container, and it doesn't allow arrays larger than 128 items.

property Container item list (cil)

To Do

• [x] Get cil from container
• [x] Add cil to player
• [x] Remove from cil when player removes an item from the container
• [x] On workbench completion, remove from the player everything in cil
• [x] Check that an item from the container is of Ingredient type before using it
• [x] Make sure the player does not see an encumbrance message when equipping a lot of ingredients. This is not a problem because the message does not appear since the player is inside the workbench menu.

Situations to worry about:

• [x] Items on the player that are not in the container
• [x] Items in the container that are not on the player
• [x] Items that are in both

Tests I need to do

• [x] Does spawning a new item that was added to the chest by my plugin cause any problems?
• [x] Do repeated workbench sessions work as expected? Do I get the right numbers of items?
• [x] Stress testing. How does it work with 200 different items?

[xanderdunn]

Improvements

• [ ] Refactor to remove ExtraContainerInfo from SkaarSpecialInventoryCrafting.cpp
• [x] Remove the script on the Player object. Use a Story Manager Event with a quest the same as the Hardcore Mode.
  • [x] Stop the quest when the player gets up from the workbench
  • [x] Make sure the quest starts again a second time around
  • [x] Remove the need for the GlobalVariable
• [x] Remove the sourceContainer property from the workbench script. Just use a linkedref and GetLinkedRef
• [x] Bug: Upon first entering the game, activate the workbench and the game will crash
• [x] Bug: SkaarAddItemsFromContainerToContainer will add some things that were in neither the source nor the destination. Look at the appearance of torches and extra lockpicks in your Misc inventory after using the workbench

[xanderdunn]

This is complete save for #34