xanderfrangos / twinkle-tray

Easily manage the brightness of your monitors in Windows from the system tray
https://twinkletray.com
MIT License
5.54k stars 182 forks source link

Hotkeys Bug #385

Open UtopieStudio opened 2 years ago

UtopieStudio commented 2 years ago

My hotkeys for Brightness up and down are: Alt + Z + arrow-up | Alt + Z + arrow-down.

I can still change the values for brightness when only holding Alt + arrow-up / down.

Same result if I hold Z down first when setting hotkeys: Z + Alt + Arrow = value can still be changed by just holding Alt without Z.

xanderfrangos commented 2 years ago

I've been able to reproduce this bug, but it isn't an easy fix. It appears to be a limitation of how Electron handles hotkeys. This may take a little while to fix. In the meantime, using additional modifiers instead of a letter (ex. Alt + Ctrl + Up) does work. It's specifically using multiple non-modifier keys that doesn't appear to work as expected.

UtopieStudio commented 2 years ago

I see, thanks for the informative reply. Problem being Ctrl and/or Shit + arrows, is text select in editors, which isn't practical. When you have something like VS Code open, you can imagine you need to think a bit for a unique hotkey. Nonetheless, using your app from sys tray is still much more convenient than reaching at the back of the monitor. I look forward to the fix in the future. Cheers.