search

xant / libhl

Simple and fast C library implementing a thread-safe API to manage hash-tables, linked lists, lock-free ring buffers and queues
GNU Lesser General Public License v3.0
420 stars 117 forks source link

reserved identifier violation #10

Closed elfring closed 9 years ago

elfring commented 9 years ago

I would like to point out that identifiers like "__tagged_value" and "_HL_HASHTABLE_H_" do eventually not fit to the expected naming convention of the C language standard. Would you like to adjust your selection for unique names?

xant commented 9 years ago

will fix by removing the underscores from all headers

dgryski commented 9 years ago

@elfring are you actually using this package or just making sure it fits a set of style guidelines?

elfring commented 9 years ago

Some uses of double underscores should also be reconsidered, shouldn't it?

Can C standard-compliance help you to reduce the error probability around specific implementation details?

xant commented 9 years ago

isn't that c++ ?

xant commented 9 years ago

19c7df2bef58f5e03f9b8a2dbbeafee5a67ec846

elfring commented 9 years ago

Thanks for your improvement of affected include guards.

There are a few update candidates left over.

xant commented 9 years ago

but those are macro arguments ... I think there is no point in changing those since their scope is limited to the actual macro implementation. Is this being reported by some analyzer?

elfring commented 9 years ago

Macro arguments are also identifiers. Would you like to clean-up the remaining source code places which tamper still with the reserved name space?