search

xantares / nfc-bindings

scripting language bindings for libnfc
BSD 3-Clause "New" or "Revised" License
23 stars 9 forks source link

Update nfc.i #4

Closed lesbeben closed 9 years ago

lesbeben commented 9 years ago

The prototype for nfc_device_get_supported_baud_rate did not match provided documentation.

Added const nfc_mode mode as second parameter to the function (as defined in libNFC >= 1.7.1).

xantares commented 9 years ago

no, that's in master: https://github.com/nfc-tools/libnfc/blob/master/include/nfc/nfc.h not in 1.7.1 tag: https://github.com/nfc-tools/libnfc/blob/libnfc-1.7.1/include/nfc/nfc.h

lesbeben commented 9 years ago

My bad, the NEWS file in the libnfc repo said 1.7.x so I assumed... Anyway you might want to change your documentation for the function in nfc.i, since it mentions the mode parameter.

xantares commented 9 years ago

5bf58d3, thanks