search

xanthian / variantbarrels

Barrels for all wood types, for your decoration needs!
MIT License
4 stars 2 forks source link

[BUG, Fabric] <Barrels playing wrong place-break noise> #16

Open Roadhog360 opened 2 months ago

Roadhog360 commented 2 months ago

Describe the bug Some barrels play the regular wood sound instead of the expected sound for that wood.

To Reproduce Place any of the following barrels: Cherry, Sakura, Crimson, warped, umbral, scorched, dark amaranth, bamboo Listen; It plays the regular wood sound instead of the correct one.

Mod Version:

Roadhog360 commented 2 months ago

I didn't realize the mod had a Forge and Fabric version. I prefer Modrinth so I didn't notice right away that CurseForge had Forge-specific builds, and hadn't looked at the branches. The issue does not occur on Forge so I've updated this ticket accordingly.

xanthian commented 2 months ago

Cant replicate this on fabric

Roadhog360 commented 2 months ago

I just tried it on Fabric without Sinytra, the issue still occurs. Clean Fabric instance with only VB and FAPI installed, here's a video. I've included the planks sounds as a reference.

https://github.com/xanthian/variantbarrels/assets/11903511/afb59566-456f-4fbd-b571-f3726e859c1d

As you can hear, even on a clean instance, with the mod being played "properly" on Fabric, the wrong sounds are still being played. FAPI 0.92.2+1.20.1, Loader 0.15.11. What does your setup look like?

xanthian commented 2 months ago

its playing the barrel sound for all barrels, are you suggesting that it should play the associated plank noise?

Roadhog360 commented 2 months ago

I mean, yeah? That's the plank sound, not the "barrel sound". Every other wood variant block, in mods and vanilla plays their respective plank's sound, because they are made of those planks, so this would make it consistent.

I would also like to note the Forge version of the mod has the correct sounds.

xanthian commented 2 months ago

You know, I've always thought that Barrel sound was different to the plank sound Turns out its not.. block.wood.place

No idea why it works on Forge though

Roadhog360 commented 2 months ago

Probably since the sources are different branches entirely instead of a common branch with fabric and Forge specific code, it's easier to have small discrepancies like this.

Yeah I was confused what you meant by the "barrel sound", it just was the wood sound, same as logs and most other wood blocks, lol.