search

xanzy / go-gitlab

GitLab Go SDK
Apache License 2.0
2.36k stars 935 forks source link

Add support for service account token expiration #1907

Closed dieterdemeyer closed 4 months ago

dieterdemeyer commented 4 months ago

When creating a Personal Access Token for a Service Account, it's possible to also pass an expiry date (optional). This PR adds support for this.

dieterdemeyer commented 4 months ago

@svanharmelen - This PR is ready for your review.

It's not my intention to be pushy but I was wondering when we could see this get merged and released. The reason for asking is because I'm currently blocked on having this feature, hence my PR to get this added 😉 If you have any feedback on the code that needs looking at, please let me know.

dieterdemeyer commented 4 months ago

@svanharmelen Thanks for merging 👍 .
Any indication on when we can expect a new release that will include this change?

svanharmelen commented 4 months ago

Uuh... Am I missing anything? v0.102.0 contains these commits right?

dieterdemeyer commented 4 months ago

My bad, I thought it only contained the drafts-support commit (when looking at the tags view) 🙃 Forget I said anything!