search

xanzy / go-gitlab

GitLab Go SDK
Apache License 2.0
2.39k stars 947 forks source link

Fix: Sync project/group resource access token webhook events to match current documentation #1930

Closed vntw closed 4 months ago

vntw commented 5 months ago

Update: After raising this issue, this merge request updated the webhook payloads that we can expect.

This PR updates the payloads and structs to reflect that ✌️

I searched for other places in the code where a format like 2024-01-24 16:27:40 UTC occurs and found (among others) this which I used as a reference:

https://github.com/xanzy/go-gitlab/blob/2c4b565c47917bc633bc2b0521802a0630b76f83/event_webhook_types.go#L832-L833

Hope that this is the correct way! Let me know if it's not

svanharmelen commented 5 months ago

Hmm... Yeah the inconsistencies around how time is used in the API is quite frustrating. In this case I guess it would make sense to first open an issue with GitLab to see if it's a bug there which they need to fix instead?

vntw commented 5 months ago

Good idea, I'll create an issue (if there hasn't been one already) and report back

e/ issue created

vntw commented 4 months ago

In this case I guess it would make sense to first open an issue with GitLab to see if it's a bug there which they need to fix instead?

Thanks again for the hint, turns out there was more to it 😃 I updated the PR with the necessary links and info.

I think this is ready now!