search

xanzy / go-gitlab

GitLab Go SDK
Apache License 2.0
2.37k stars 940 forks source link

fix: Change VariableType type from string to VariableTypeValue #1969

Closed perrze closed 2 months ago

perrze commented 2 months ago

Hi, I changed the type of VariableType in pipelines.go, jobs.go and pipeline_schedules.go PipelineVariable Object from string to VariableTypeValue. Indeed in group_variables.go line 123 the CreateGroupVariableOptions had this type for VariableType for example and I didn't find a reason why it would be different.

It passes test and gofumpt. I hope it will be useful ! Have a nice day