search

xanzy / go-gitlab

GitLab Go SDK
Apache License 2.0
2.43k stars 961 forks source link

Fix an issue with omitempty on default_branch_protection_defaults #2004

Closed RicePatrick closed 2 months ago

RicePatrick commented 2 months ago

This PR fixes an issue where the omitempty tag on the new DefaultBranchProtectionDefaults uses a period instead of a comma for allowed_to_merge, resulting in the create and update requests not properly updating the merge options.

RicePatrick commented 2 months ago

@svanharmelen - Would you mind cutting a new version when you have a free moment? There's a MR on the terraform provider that depends on this fix :)

svanharmelen commented 2 months ago

Done 👍🏻