search

xanzy / go-gitlab

GitLab Go SDK
Apache License 2.0
2.42k stars 960 forks source link

Add consts for all webhook actions #2032

Open puerco opened 1 month ago

puerco commented 1 month ago

This PR defines constants for all the event webhook action types sent by GitLab.

It also reuses EventActionCreate and EventActionUpdate to define the custom CommentEventType values already defined in the module.

puerco commented 1 month ago

I noticed that comments have their own custom action type:

https://github.com/xanzy/go-gitlab/blob/b5e0812497a6475cf9d5f55c068ee0c3a44dbe7a/event_webhook_types.go#L272-L274

but the rest of the payload types have their action typed as string:

https://github.com/xanzy/go-gitlab/blob/b5e0812497a6475cf9d5f55c068ee0c3a44dbe7a/event_webhook_types.go#L1050-L1052

so I didn't add any more specific ones.

This is not modifying any of them, only defining them

puerco commented 1 month ago

My main goal as a user is to expose the values of the action from the library to applications. I didn't want to modify the payload types in event_webhook_types.go to use them not to break compatibility but I can if you are fine with it! It would certainly be better.

svanharmelen commented 1 month ago

Yeah while it might cause a few issues, I think it's the best what to actually guarantee the list will stay up-to-date over time. So I would say go ahead and update the EventType fields to use this new const.